Skip to content

feat: gradle 8, kotlin 2.0 #1812

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 48 commits into from
Jul 2, 2024
Merged

feat: gradle 8, kotlin 2.0 #1812

merged 48 commits into from
Jul 2, 2024

Conversation

triniwiz
Copy link
Member

No description provided.

@cla-bot cla-bot bot added the cla: yes label Apr 15, 2024
@triniwiz
Copy link
Member Author

Adds the following

  • Gradle 8
  • kotlin 2.0
  • java 17
  • kotlin enabled by default

@triniwiz triniwiz marked this pull request as ready for review April 16, 2024 09:24
Comment on lines +190 to +191
compileSdk computeCompileSdkVersion()
buildToolsVersion = computeBuildToolsVersion()

This comment was marked as outdated.

@ammarahm-ed
Copy link
Contributor

Hey @triniwiz, we need this too in app/build.gradle before tasks.configureEach

rootProject.subprojects.forEach {
  it.tasks.configureEach({ DefaultTask currentTask ->
    if (currentTask =~ /.+bundleLibCompileToJar.*/) {
      cleanupAllJars.dependsOn currentTask
    }
  })
}

This fixes this error with adding open-native since it adds subprojects alongside :app subproject.

Gradle detected a problem with the following location: '/Volumes/DataDrive/Projects/nativescript/open-native/packages/core/react-android/react/build/intermediates/compile_library_classes_jar/debug/bundleLibCompileToJarDebug/classes.jar'.
    
    Reason: Task ':app:cleanupAllJars' uses this output of task ':react:bundleLibCompileToJarDebug' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.
    
    Possible solutions:
      1. Declare task ':react:bundleLibCompileToJarDebug' as an input of ':app:cleanupAllJars'.
      2. Declare an explicit dependency on ':react:bundleLibCompileToJarDebug' from ':app:cleanupAllJars' using Task#dependsOn.
      3. Declare an explicit dependency on ':react:bundleLibCompileToJarDebug' from ':app:cleanupAllJars' using Task#mustRunAfter.
    
    For more information, please refer to https://docs.gradle.org/8.4/userguide/validation_problems.html#implicit_dependency in the Gradle documentation.

@edusperoni edusperoni force-pushed the feat/gradle-8-y-kotlin-2-0 branch from 5519981 to 2fb5aa2 Compare July 2, 2024 20:16
@NathanWalker NathanWalker merged commit d4b7164 into main Jul 2, 2024
3 checks passed
@NathanWalker NathanWalker deleted the feat/gradle-8-y-kotlin-2-0 branch July 2, 2024 22:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants