Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fixes #369 long paths on window #419

Merged
merged 7 commits into from
Apr 14, 2016
Merged

Conversation

blagoev
Copy link
Contributor

@blagoev blagoev commented Apr 12, 2016

A possible temporary fix for the long paths on Windows builds when multiple {N} plugins are used.

blagoev added 2 commits April 12, 2016 23:05
A possible temporary fix for the long paths on Windows builds when multiple {N} plugins are used.
@ns-bot
Copy link

ns-bot commented Apr 12, 2016

💚

1 similar comment
@ns-bot
Copy link

ns-bot commented Apr 12, 2016

💚

@ns-bot
Copy link

ns-bot commented Apr 13, 2016

💚

@ns-bot
Copy link

ns-bot commented Apr 13, 2016

💚

1 similar comment
@ns-bot
Copy link

ns-bot commented Apr 13, 2016

💚

@blagoev
Copy link
Contributor Author

blagoev commented Apr 13, 2016

@Plamen5kov @atanasovg Have a look at this. Improves the situation with long paths.
Still the feel is product flavors and dimensions should not be used for the scenario we are trying to cover. Ultimately should switch the approach

Also @teobugslayer if interested to try.

@ns-bot
Copy link

ns-bot commented Apr 13, 2016

💚

@atanasovg
Copy link
Contributor

👍
@blagoev This does look hacky :) But, as discussed, this is the only viable option for now. Does this change introduce some delay in the build time?

@blagoev
Copy link
Contributor Author

blagoev commented Apr 13, 2016

no any noticable delays.

@NathanaelA

This comment was marked as abuse.

@blagoev
Copy link
Contributor Author

blagoev commented Apr 13, 2016

Yes it does try to workaround the current issue by shortening the flavor names. It seems you are right it does not handle AndroidManifest merging since I forgot to fix the dir names. fix comming in a sec.

fixes merging of flavor provided AndroidManifest and resources
@blagoev
Copy link
Contributor Author

blagoev commented Apr 13, 2016

@NathanaelA just to bring you up to speed with why the manifest and resources are not merged when flavor name changes. CLI is copying all plugins to platforms/android/src/[plugin name] directory. When the flavor name is changed this [plugin name] directory should also change name.

@ns-bot
Copy link

ns-bot commented Apr 13, 2016

💚

@Plamen5kov
Copy link
Contributor

👍

@blagoev blagoev merged commit 4ba7f3b into master Apr 14, 2016
@slavchev slavchev deleted the fix-long-paths-build-on-windows branch April 19, 2016 13:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants