Skip to content

Plamen5kov/refactored 5.2.361 #536

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 36 commits into from
Sep 26, 2016
Merged

Conversation

Plamen5kov
Copy link
Contributor

@Plamen5kov Plamen5kov commented Aug 14, 2016

Work in progress:

  • update binary files and includes
  • refactor android runtime to use new APIs
  • run unit tests
  • research new API for external heap tracing (replace gc augmented logic when marking js objects)
  • research new features (snapshot, blob, microtasks ...)
  • run unit tests with debug version of v8 (make further api adjustments if necessary)
  • refactored so setPrivate/getPrivate (setHiddenField/getHiddenField) is now called from one place
  • objectManager now has member Isolate
  • additional file: runtime/src/main/jni/include/OWNERS
  • prototypeTemplate.set(name, Wrap()) is broken. Need to fix profiler.

EDIT: tests pass on:

  • emulator x86 - api level 23
  • emulator x86 - api level 17
  • emulator x86 - api level 21
  • emulator x64 - api level 23
  • device arm-x64 - api level 23
  • device arm - api level 23
  • device arm - api level 21

Update v8 to version 5.2.361

Description

This PR should update the v8 to the latest stable version which supports the ES6 on 97%. See more. This will be a stepping stone for us to be able to use es6, from typescript transpiled code.

Does your commit message include the wording below to reference a specific issue in this repo?

#496
#191

Related Pull Requests

None

@NativeScript/android-runtime, please take a look at the PR

@ns-bot
Copy link

ns-bot commented Aug 14, 2016

💚

1 similar comment
@ns-bot
Copy link

ns-bot commented Aug 16, 2016

💚

@Plamen5kov Plamen5kov force-pushed the plamen5kov/refactored_5.2.361 branch from 92f2c50 to ab65a4f Compare August 17, 2016 06:41
@ns-bot
Copy link

ns-bot commented Aug 17, 2016

💚

@blagoev
Copy link
Contributor

blagoev commented Aug 17, 2016

Fix for setting prototypeTemplate with the wrapped function https://github.com/NativeScript/android-runtime/tree/pr/n536_Plamen5kov

@petekanev
Copy link
Contributor

👍

@Plamen5kov Plamen5kov force-pushed the plamen5kov/refactored_5.2.361 branch from ab65a4f to 65bca5d Compare August 20, 2016 08:14
@ns-bot
Copy link

ns-bot commented Aug 20, 2016

💚

1 similar comment
@ns-bot
Copy link

ns-bot commented Aug 23, 2016

💚

@petekanev petekanev force-pushed the plamen5kov/refactored_5.2.361 branch from 4c943c0 to 854fef4 Compare August 23, 2016 10:30
@ns-bot
Copy link

ns-bot commented Aug 23, 2016

💔

@ns-bot
Copy link

ns-bot commented Aug 23, 2016

💚

1 similar comment
@ns-bot
Copy link

ns-bot commented Aug 24, 2016

💚

@blagoev
Copy link
Contributor

blagoev commented Aug 24, 2016

run ci

@ns-bot
Copy link

ns-bot commented Aug 24, 2016

💚

@ns-bot
Copy link

ns-bot commented Aug 24, 2016

💔

3 similar comments
@ns-bot
Copy link

ns-bot commented Aug 24, 2016

💔

@ns-bot
Copy link

ns-bot commented Aug 24, 2016

💔

@ns-bot
Copy link

ns-bot commented Aug 24, 2016

💔

@ns-bot
Copy link

ns-bot commented Aug 25, 2016

💚

@ns-bot
Copy link

ns-bot commented Aug 25, 2016

💔

2 similar comments
@ns-bot
Copy link

ns-bot commented Aug 25, 2016

💔

@ns-bot
Copy link

ns-bot commented Aug 25, 2016

💔

@blagoev
Copy link
Contributor

blagoev commented Aug 25, 2016

run ci

@ns-bot
Copy link

ns-bot commented Aug 25, 2016

💚

@ns-bot
Copy link

ns-bot commented Aug 25, 2016

💔

@blagoev
Copy link
Contributor

blagoev commented Aug 25, 2016

run ci

@ns-bot
Copy link

ns-bot commented Aug 25, 2016

💚

2 similar comments
@ns-bot
Copy link

ns-bot commented Aug 25, 2016

💚

@ns-bot
Copy link

ns-bot commented Aug 25, 2016

💚

@petekanev petekanev force-pushed the plamen5kov/refactored_5.2.361 branch from 8f35536 to f7a4144 Compare September 26, 2016 07:40
@ns-bot
Copy link

ns-bot commented Sep 26, 2016

💚

@petekanev petekanev merged commit de156ec into master Sep 26, 2016
@petekanev petekanev deleted the plamen5kov/refactored_5.2.361 branch October 11, 2016 11:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants