Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Enable requiring of JSON files #294

Closed
atanasovg opened this issue Sep 9, 2015 · 2 comments
Closed

Enable requiring of JSON files #294

atanasovg opened this issue Sep 9, 2015 · 2 comments
Assignees
@jasssonpet
Labels
done feature severity: medium
Milestone
1.5.1

Comments

@atanasovg
Copy link
Contributor

Copied from NativeScript/android#217

Node has the feature to read and automatically parse JSON files through its require routine. This is a handy little feature that Node developers are used to, so we may consider implementing it.

See NativeScript/android#215 for more information.
@jasssonpet jasssonpet changed the title Enable requiring of JSON files (like in Node) Enable requiring of JSON files Sep 12, 2015
@jasssonpet jasssonpet added this to the 1.5.1 (Under review) milestone Nov 28, 2015
@jasssonpet
Copy link
Contributor

Moving this to 1.5.1 since the Android runtime is implementing it: NativeScript/android#217.

I wonder if JSON objects should be cached the way modules are?

@jasssonpet jasssonpet self-assigned this Dec 2, 2015
jasssonpet added a commit that referenced this issue Dec 2, 2015
@jasssonpet
Require json files - close #294
c699b49
@jasssonpet
Copy link
Contributor

After a live discussion with @slavchev we decided that JSON objects should be cached.

jasssonpet added a commit that referenced this issue Dec 2, 2015
@jasssonpet
Require json files - close #294
d413ade
jasssonpet added a commit that referenced this issue Dec 3, 2015
@jasssonpet
Require json files - close #294
d32d059
jasssonpet added a commit that referenced this issue Dec 3, 2015
@jasssonpet
Require json files - close #294
f92ffe7
jasssonpet added a commit that referenced this issue Dec 3, 2015
@jasssonpet
Require json files - close #294
c5a6c18
fealebenpae added a commit that referenced this issue Dec 7, 2015
@fealebenpae
Merge pull request #428 from NativeScript/jasssonpet/require-json
184ba34 
Require json files - close #294
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@jasssonpet jasssonpet

Labels
done feature severity: medium
Projects
None yet
Milestone
1.5.1
Development

No branches or pull requests
2 participants
@jasssonpet @atanasovg