Skip to content

fix: skip log-source-maps for large files #5780

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

rigor789
Copy link
Member

@rigor789 rigor789 commented Jan 17, 2024

PR Checklist

What is the current behavior?

Large files in the output directory can crash node/v8.

What is the new behavior?

We skip reading files larger than 50mb as those are unlikely to be source code anyways. This doesn't affect anything but logs - where larger files would just log their actual stack traces rather than a source-mapped one. In practice source would rarely if ever be >50mb though.

@cla-bot cla-bot bot added the cla: yes label Jan 17, 2024
@rigor789 rigor789 merged commit c53b4e9 into main Jan 17, 2024
@rigor789 rigor789 deleted the fix/log-source-map-skip-large-files branch January 17, 2024 01:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant