Skip to content

Commit

Permalink
Remove commented out conformance tests
Browse files Browse the repository at this point in the history
  • Loading branch information
lgoettgens committed Apr 26, 2024
1 parent f86a25c commit 89003c5
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 12 deletions.
1 change: 1 addition & 0 deletions src/generic/GenericTypes.jl
Original file line number Diff line number Diff line change
Expand Up @@ -458,6 +458,7 @@ end
###############################################################################

# Q: Why is SparsePolyRing not a subtype of AbstractAlgebra.PolyRing{T} ?
# A: It is purely internal, and implementing the interface would make it slower.

@attributes mutable struct SparsePolyRing{T <: RingElement} <: AbstractAlgebra.Ring
base_ring::Ring
Expand Down
12 changes: 0 additions & 12 deletions test/generic/SparsePoly-test.jl
Original file line number Diff line number Diff line change
@@ -1,15 +1,3 @@
# FIXME/TODO: get these conformance tests to work and pass
#function test_elem(Rx::AbstractAlgebra.Generic.SparsePolyRing)
# R = base_ring(Rx)
# x = gen(Rx)
# return sum(x^(5*i) * test_elem(R) for i in 1:rand(0:6); init=zero(Rx))
#end
#
#@testset "Generic.SparsePoly.conformance" begin
# R, x = SparsePolynomialRing(ZZ, "x")
# test_Ring_interface(R)
#end

@testset "Generic.SparsePoly.constructors" begin
SparsePolynomialRing = AbstractAlgebra.SparsePolynomialRing

Expand Down

0 comments on commit 89003c5

Please # to comment.