Try to sort out the homs

Nemocas · May 3, 2024 · fdf0b25 · fdf0b25
1 parent 1f2ae64
commit fdf0b25
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/src/exports.jl b/src/exports.jl
@@ -241,6 +241,7 @@ export hnf_via_popov
 export hnf_via_popov_with_transform
 export hnf_with_transform
 export hom
+export hom_direct_sum
 export hooklength
 export ideal
 export identity_map

diff --git a/src/generic/DirectSum.jl b/src/generic/DirectSum.jl
@@ -252,12 +252,12 @@ function ModuleHomomorphism(D::DirectSumModule{T}, A::DirectSumModule{T}, m::Mat
    return ModuleHomomorphism(D, A, transpose(hvcat(Tuple([length(SD) for i = 1:length(SA)]), map(x->transpose(x.matrix), m)...)))
 end
 
-function hom(M::DirectSumModule{T}, N::DirectSumModule{T}, mp::Vector{ModuleHomomorphism{T}}) where T
+function hom_direct_sum(M::DirectSumModule{T}, N::DirectSumModule{T}, mp::Vector{ModuleHomomorphism{T}}) where T
   @assert length(M.m) == length(mp) == length(N.m)
   return hom(M, N, cat(map(matrix, mp)..., dims = (1,2)))
 end
 
-function hom(A::DirectSumModule{T}, B::DirectSumModule{T}, M::Matrix{<:Map{<:AbstractAlgebra.FPModule{T}, <:AbstractAlgebra.FPModule{T}}}) where {T}
+function hom_direct_sum(A::DirectSumModule{T}, B::DirectSumModule{T}, M::Matrix{<:Map{<:AbstractAlgebra.FPModule{T}, <:AbstractAlgebra.FPModule{T}}}) where {T}
   pro = canonical_projections(A)
   im = canonical_injections(B)
   s = hom(A, B, [zero(B) for i = 1:dim(A)])

diff --git a/src/generic/exports.jl b/src/generic/exports.jl
@@ -35,6 +35,7 @@ export groebner_basis
 export has_bottom_neighbor
 export has_left_neighbor
 export hash
+export hom_direct_sum
 export hooklength
 export image_fn
 export image_map