Error for commiting without staging

[TakenMC]

Is your feature request related to a problem? Please describe.
Not really tho seeing an error message makes it seem something bad happened

Describe the solution you'd like
If no files are currently staged it would be nice to have a message say "Please stage files before commiting" same as the message when pushing and pulling

Describe alternatives you've considered
I have none

Additional context
The request seems self explanatory

[ten3roberts]

Good idea.

I suppose that the error you are getting now is the underlying git commit error of "no changes added to commit" and makes it sound like the world is about to end.

This would be covered by the aforementioned git output parsing in #537. Feel free to add a comment under that issue for a git error which can be parsed and recognized.

[TakenMC]

ok

[CKolkey]

Well, the possible issue is that you can do an empty commit with the --allow-empty flag, so... and empty commit is valid. Maybe parsing and explaining to the user more concisely what went wrong is the way to go

[rami3l]

@CKolkey Thanks for making 9e3ae89!

However, didn't this make git commit --allow-empty no longer possible, since it is currently covered in the early-returning branch?

[CKolkey]

Thanks - fixed: 568415f (#1594) 😅