Add support to "AT_TIMESTAMP" ShardIteratorType #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As documented here: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/kinesis.html#Kinesis.Client.get_shard_iterator I think those lines may be enough to support AT_TIMESTAMP behavior. It is not tested yet. It should be used this way: ```python3 from kinesis.consumer import KinesisConsumer consumer = KinesisConsumer(stream_name='my-stream', start_at_timestamp='20190901') for message in consumer: print "Received message: {0}".format(message) ``` Regards, M0dM
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
==========================================
+ Coverage 32.98% 33.56% +0.58%
==========================================
Files 4 4
Lines 285 289 +4
==========================================
+ Hits 94 97 +3
- Misses 191 192 +1
Continue to review full report at Codecov.
|
|
I can confirm the above code is working for me. Regards, |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented here:
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/kinesis.html#Kinesis.Client.get_shard_iterator
I think those lines may be enough to support AT_TIMESTAMP behavior.
It is not tested yet.
It should be used this way:
Regards,
M0dM