Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(build): migrate to esm from cjs BREAKING_CHANGE #690

Closed
wants to merge 3 commits into from

Conversation

aorinevo
Copy link
Collaborator

@aorinevo aorinevo commented Feb 3, 2024

Changes

BREAKING_CHANGE: This PR migrates Shepherd codebase to ESM from CJS.

Benefits

Highlights

Todo

  1. Fix Jest runner: import paths do not resolve due to use of .js extension vs .ts.
  2. Drop support for Node <= 18.
  3. Fix workflow (e.g., linting step).

Local Test Screenshots

Screenshot 2024-02-03 at 5 31 58 PM

@aorinevo aorinevo self-assigned this Feb 3, 2024
@aorinevo aorinevo added the enhancement New feature or request label Feb 3, 2024
@aorinevo aorinevo force-pushed the feat/migrate-to-esm branch from 2577465 to 3fe66ce Compare February 3, 2024 22:25
@aorinevo aorinevo changed the title WIP: feat(build): migrate to esm from cjs WIP: feat(build): migrate to esm from cjs BREAKING_CHANGE Feb 3, 2024
@aorinevo aorinevo changed the title WIP: feat(build): migrate to esm from cjs BREAKING_CHANGE feat(build): migrate to esm from cjs BREAKING_CHANGE Feb 3, 2024
@aorinevo aorinevo force-pushed the feat/migrate-to-esm branch from 3fe66ce to af581f1 Compare February 3, 2024 22:39
@aorinevo
Copy link
Collaborator Author

aorinevo commented Feb 3, 2024

Not sure why, but the linting step, while successful, ultimately gets canceled (see screenshot).

Screenshot 2024-02-03 at 5 50 06 PM

@aorinevo aorinevo force-pushed the feat/migrate-to-esm branch 3 times, most recently from 0e769d7 to 8e816b1 Compare February 4, 2024 01:48
@aorinevo aorinevo force-pushed the feat/migrate-to-esm branch from 8e816b1 to 2d187fd Compare February 4, 2024 01:51
@aorinevo
Copy link
Collaborator Author

aorinevo commented Feb 4, 2024

Issue is likely due to the fact that node.matrix contained Node v22 which hasn't been released yet.

@aorinevo
Copy link
Collaborator Author

aorinevo commented Oct 3, 2024

Close in favor of #846

@aorinevo aorinevo closed this Oct 3, 2024
@aorinevo aorinevo deleted the feat/migrate-to-esm branch October 3, 2024 05:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for esm modules
2 participants