fix: margin/padding 为 0 被忽略

NervJS · Oct 27, 2023 · b9eeec0 · b9eeec0
1 parent d5f6091
commit b9eeec0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 20 deletions.
diff --git a/src/style_parser.rs b/src/style_parser.rs
@@ -113,13 +113,8 @@ pub fn parse_style_properties(properties: &Vec<(String, Property<'_>)>) -> Style
   for (id, value) in properties.iter() {
     match id.as_str() {
       "margin" => {
-        let margin = MarginPadding::from(value);
-        if margin.is_zero() {
-          final_properties.remove("margin");
-        } else {
-          final_properties.insert("margin".to_string(), StyleValueType::MarginPadding(margin));
-        }
-      }
+        final_properties.insert("margin".to_string(), StyleValueType::MarginPadding(MarginPadding::from(value)));
+      },
       "marginLeft" => {
         let margin = final_properties
           .entry("margin".to_string())
@@ -173,15 +168,7 @@ pub fn parse_style_properties(properties: &Vec<(String, Property<'_>)>) -> Style
         }
       }
       "padding" => {
-        let padding = MarginPadding::from(value);
-        if padding.is_zero() {
-          final_properties.remove("padding");
-        } else {
-          final_properties.insert(
-            "padding".to_string(),
-            StyleValueType::MarginPadding(padding),
-          );
-        }
+        final_properties.insert("padding".to_string(), StyleValueType::MarginPadding(MarginPadding::from(value)));
       }
       "paddingLeft" => {
         let padding = final_properties

diff --git a/src/style_transform/margin_padding.rs b/src/style_transform/margin_padding.rs
@@ -22,10 +22,6 @@ impl MarginPadding {
     }
   }
 
-  pub fn is_zero(&self) -> bool {
-    self.top == "0" && self.right == "0" && self.bottom == "0" && self.left == "0"
-  }
-
   pub fn set_top(&mut self, top: &str) {
     self.top = top.to_string();
   }