Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Replace smart_str by smart_bytes in order to be compatible with python 3 #2

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

Yukilas
Copy link

@Yukilas Yukilas commented Nov 29, 2021

The raw_password and salt variables have to be bytes-strings, this is need for the hashlib methods.
For now the code works in python 2 but not in python 3, the current smart_str function does not convert the python 3 unicode string into bytes-string.
With the smart_bytes function, it works for both python 2 and 3.

I bumped the version number to 0.6 so for now we can keep using the current 0.5 version and only use the new one in chuck's python 3 branches.

@Yukilas Yukilas self-assigned this Nov 29, 2021
@Yukilas Yukilas requested a review from mikeocool November 29, 2021 15:47
@Yukilas Yukilas merged commit 05829b6 into master Dec 9, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant