adding types annotations and py 2.7 support

[aogier]

dear maintainers, since I have recently started using this library a lot I would like to contribute a patch with types annotations so I stop putting comments for mypy :D

Seeing the code I find some parts with workarounds to support python 2.7 and although in setup.py I see a requirement >= 3.7 I am not sure if this compatibility is somehow a requirement of the project, which in this case would stop me from contributing on that.

What do you think? Are you interested in such a contribution ? I could also write a stub and put on the usual typeshed repo but I'd prefer to work on this upstream.

Thank you, regards

[scriptsrc]

I’m okay moving requirements to only support more recent python versions with type annotations. Patrick Sanders - do you agree? Sounds like that would be an awesome contribution!

…

On Sun, Jul 16, 2023 at 2:14 AM Alessandro Ogier ***@***.***> wrote: dear maintainers, since I have recently started using this library a lot I would like to contribute a patch with types annotations so I stop putting comments for mypy :D Seeing the code I find some parts with workarounds to support python 2.7 and although in setup.py I see a requirement >= 3.7 I am not sure if this compatibility is somehow a requirement of the project, which in this case would stop me from contributing on that. What do you think? Are you interested in such a contribution ? I could also write a stub and put on the usual typeshed repo but I'd prefer to work on this upstream. Thank you, regards — Reply to this email directly, view it on GitHub <#176>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5DLJUWJCQS6ZGOLYXSN2TXQOPGFANCNFSM6AAAAAA2LZJCLU> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[patricksanders]

This sounds great. I'm cool with dropping support for all EOL versions, which would bring us up to >= 3.8.

Thanks for your interest in contributing!

[aogier]

ok cool! I'll work on it, for now on my spare time so not very fast iterations but I hope to reach something working well enough soon then you will help me w/ what I'll miss out for sure and also my company will hopefully sponsor w/ my paid time sooner or later. Thank you! :)