WIP: Adding check for bucket sniping #145
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey y'all, wanted to circle around on #142 - this is a WIP PR which adds a "may_be_internet_accessible" check to policies/statements for inconclusive checks, as opposed to "is_internet_accessible" which is definite.
I'll be totally honest, I don't really feel like doing this in policy.py/statement.py is the right choice, as this starts to overload the class and could be a pain. Especially if more is added down the line, such as checking for ForAllValues conditions which could fail open (i.e. optional keys, which could be a null set).
I think splitting policy 'advisories' as it were to a new file might be helpful, though that would take some re-architecting, and I'm happy to pursue a demo of that as well.
It's also totally acceptable to say "Holy scope creep, Batman! This is going to be more trouble than it's worth, let's hold off" :)