-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Switching data source to iamdata, removing updater, and updating docs and tests. #187
base: master
Are you sure you want to change the base?
Conversation
I guess this would fix #186 |
policyuniverse/__init__.py
Outdated
@@ -22,8 +22,8 @@ | |||
|
|||
service_data = json.load(open(service_data_path, "r")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would make more sense to update this to service_data = IAMData()
and keep the signature the same on build_action_categories_from_service_data()
and build_service_actions_from_service_data()
. That way we only incur the file read and JSON parsing overhead once on import.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
I believe this is ready to go now. |
@patricksanders never mind, i confuse myself with https://github.com/cloud-copilot/iam-data-python with https://github.com/cloud-copilot/iam-data The script that generate the updated data is GPL and the data package is MIT license. iam-data is underneath the https://github.com/cloud-copilot organization. Can we have some insight on the governance structure of the iam-data-python. Being the data source of security, visibility of the supply chain is quite important. |
@smoy, yeah like you said: https://github.com/cloud-copilot/iam-data-python is MIT which is where the data is coming from. I have a process that runs nightly and publishes the updated packages. The script that generates the data is not open source at this time. There is nothing interesting or earth shattering in there, it just hasn't been open sourced yet. |
Switching data source to the iamdata package and updating tests.
If this looks good we can update docs.