Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Switching data source to iamdata, removing updater, and updating docs and tests. #187

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

davekerber
Copy link

Switching data source to the iamdata package and updating tests.

If this looks good we can update docs.

@lucaippi
Copy link

I guess this would fix #186

@@ -22,8 +22,8 @@

service_data = json.load(open(service_data_path, "r"))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make more sense to update this to service_data = IAMData() and keep the signature the same on build_action_categories_from_service_data() and build_service_actions_from_service_data(). That way we only incur the file read and JSON parsing overhead once on import.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@davekerber davekerber changed the title Draft: Switching data source to iamdata and updating tests. Switching data source to iamdata, removing updater, and updating docs and tests. Oct 30, 2024
@davekerber
Copy link
Author

I believe this is ready to go now.

@smoy
Copy link
Contributor

smoy commented Oct 31, 2024

@patricksanders I want to raise iam-data is currently license as GPL 3.0, which I AFAIK is not compatible with policyuniverse existing Apache 2.0 license.

never mind, i confuse myself with https://github.com/cloud-copilot/iam-data-python with https://github.com/cloud-copilot/iam-data

The script that generate the updated data is GPL and the data package is MIT license.

iam-data is underneath the https://github.com/cloud-copilot organization. Can we have some insight on the governance structure of the iam-data-python. Being the data source of security, visibility of the supply chain is quite important.

@davekerber
Copy link
Author

@smoy, yeah like you said: https://github.com/cloud-copilot/iam-data-python is MIT which is where the data is coming from.

I have a process that runs nightly and publishes the updated packages. The script that generates the data is not open source at this time. There is nothing interesting or earth shattering in there, it just hasn't been open sourced yet.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants