Skip to content

Introduce support for container secrets for @kubernetes #1261

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
savingoyal opened this issue Feb 6, 2023 · 2 comments · May be fixed by #2400
Open

Introduce support for container secrets for @kubernetes #1261

savingoyal opened this issue Feb 6, 2023 · 2 comments · May be fixed by #2400

Comments

@savingoyal
Copy link
Collaborator

savingoyal commented Feb 6, 2023 •
edited
Loading

as an alternate to https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/#add-imagepullsecrets-to-a-service-account
@GregAru
Copy link

GregAru commented Mar 6, 2023

Any news with this issue? The secrets support is pretty basic requirement to be able to use Metaflow with AKS.

@savingoyal
Copy link
Collaborator Author

@GregAru it is on our short term roadmap to add image pull secrets to Metaflow but that shouldn't block Metaflow usage at all given that one can add those to the service account today (as linked in the URL above)

nschmeller added a commit to nschmeller/metaflow that referenced this issue May 8, 2025
@nschmeller
feat: kubernetes image pull secrets
efd6ee0 
This commit adds support for specifying Kubernetes container
image pull secrets in the `kubernetes` step decorator.

As an example:

```python
@kubernetes(
    image='docker.io/some-private-repo/image',
    image_pull_secrets=['regcred']
)
@step
def some_step:
    ...
```

Example output from `kubectl describe pod <some-pod>` on the
`metaflow-dev` stack where `metaflow` was installed via
`pip install -e </path/to/repo/checkout>:

```console
Events:
  Type    Reason     Age   From               Message
  ----    ------     ----  ----               -------
  Normal  Scheduled  1m   default-scheduler  Successfully assigned default/t-f03abf3d-2rpgp-j72q8 to minikube
  Normal  Pulling    1m   kubelet            Pulling image "docker.io/some-private-repo/image"
  Normal  Pulled     1m   kubelet            Successfully pulled image "docker.io/some-private-repo/image" in 669ms (670ms including waiting)
  Normal  Created    1m   kubelet            Created container some-step
  Normal  Started    1m   kubelet            Started container some-step
```

Resolves Netflix#1261
@nschmeller nschmeller linked a pull request May 8, 2025 that will close this issue
Open
nschmeller added a commit to nschmeller/metaflow that referenced this issue May 8, 2025
@nschmeller
feat: kubernetes image pull secrets
4a95938 
This commit adds support for specifying Kubernetes container
image pull secrets in the `kubernetes` step decorator.

As an example:

```python
@kubernetes(
    image='docker.io/some-private-repo/image',
    image_pull_secrets=['regcred']
)
@step
def some_step:
    ...
```

Example output from `kubectl describe pod <some-pod>` on the
`metaflow-dev` stack where `metaflow` was installed via
`pip install -e </path/to/repo/checkout>`:

```console
Events:
  Type    Reason     Age   From               Message
  ----    ------     ----  ----               -------
  Normal  Scheduled  1m   default-scheduler  Successfully assigned
default/t-f03abf3d-2rpgp-j72q8 to minikube
  Normal  Pulling    1m   kubelet            Pulling image
"docker.io/some-private-repo/image"
  Normal  Pulled     1m   kubelet            Successfully pulled image
"docker.io/some-private-repo/image" in 669ms (670ms including waiting)
  Normal  Created    1m   kubelet            Created container some-step
  Normal  Started    1m   kubelet            Started container some-step
```

Resolves Netflix#1261
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: kubernetes image pull secrets nschmeller/metaflow
2 participants
@savingoyal @GregAru