Fix issues with configs and Runner #2234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
romain-intel
commented
Jan 30, 2025
romain-intel
commented
- Rename config_file to config to make it consistent with the Click API
- Allow CustomFlowDecorators to work with Runner (currently, it was not finding the FlowSpec)
- Remove hidden options from Click API
- Small other fixes to get Runner to work with various combinations of CustomFlowDecorators and CustomStepDecorators
savingoyal
previously approved these changes
Jan 31, 2025
|
pending conflict resolution |
- Rename config_file to config to make it consistent with the Click API - Allow CustomFlowDecorators to work with Runner (currently, it was not finding the FlowSpec) - Remove hidden options from Click API - Small other fixes to get Runner to work with various combinations of CustomFlowDecorators and CustomStepDecorators
romain-intel
force-pushed
the
fix/mlpmf-282
branch
from
922b9d1 to
60c73c0
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.