core: add checks to chunked encoding for http/2 #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artgon
reviewed
Jan 20, 2021
| private long seenContentLength; | ||
|
|
||
| @Override | ||
| public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception { |
There was a problem hiding this comment.
It might be useful to add a comment for each type of violation that you're checking against.
There was a problem hiding this comment.
I added a comment block at the top.
artgon
approved these changes
Jan 20, 2021
argha-c
approved these changes
Jan 20, 2021
| } | ||
| if (msg instanceof HttpContent) { | ||
| ByteBuf content = ((HttpContent) msg).content(); | ||
| seenContentLength = Math.addExact(seenContentLength, content.readableBytes()); |
There was a problem hiding this comment.
Suggest extracting this into a method, for readability. It's stateful and the increment isn't obvious immediately.
| return; | ||
| } | ||
| } | ||
| if (expectedContentLength != UNSET_CONTENT_LENGTH && HttpUtil.isTransferEncodingChunked(req)) { |
There was a problem hiding this comment.
Consider extracting usages of expectedContentLength != UNSET_CONTENT_LENGTH and naming appropriately to convey the intent of that check.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.