upload-certificate: improve validation step output #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make the validation step more usable from the UI, the following improvements are made: * Redirect non-JSON error messages to stderr * Properly signal a validation error to the agent * Print a properly formatted JSON error message to stdout in case of validation failure
Amygos
force-pushed
the
improve_custom_cert_validation
branch
from
19835ed to
d8510fb
Compare
Tbaile
approved these changes
Sep 5, 2024
DavidePrincipi
approved these changes
Sep 5, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the validation step more usable from the UI, the following improvements are made:
NethServer/dev#6986