Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Fix] instantaneous rate with list[neo.SpikeTrain] #649

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Moritz-Alexander-Kern
Copy link
Member

@Moritz-Alexander-Kern Moritz-Alexander-Kern commented Nov 15, 2024

The pull request addresses inconsistent behavior with different options in combination with various inputs, specifically:

Issue:

  • pool_spiketrains = True with list[spiketrains] does not pool spiketrains as expected. The output should be a single neo.AnalogSignal.

Fix

  • check for other types, previously only neo.spiketrainlist was regarded
  • add tests

@coveralls
Copy link
Collaborator

coveralls commented Nov 15, 2024

Coverage Status

coverage: 88.405% (+0.1%) from 88.262%
when pulling 0df030d on INM-6:fix/instantaneous_rate
into bb0a394 on NeuralEnsemble:master.

@Moritz-Alexander-Kern Moritz-Alexander-Kern added this to the v1.2.0 milestone Dec 10, 2024
@Moritz-Alexander-Kern Moritz-Alexander-Kern changed the title [Fix] instantaneous rate with trials [Fix] instantaneous rate with list[neo.SpikeTrain] Jan 20, 2025
@Moritz-Alexander-Kern Moritz-Alexander-Kern marked this pull request as ready for review January 20, 2025 12:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants