-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Moya Network 모듈 세팅 #11
Merged
enebin
merged 10 commits into
feature/push&deeplink-setting
from
feature/network-module
Jul 20, 2023
Merged
Moya Network 모듈 세팅 #11
enebin
merged 10 commits into
feature/push&deeplink-setting
from
feature/network-module
Jul 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
k906506
reviewed
Jul 16, 2023
k906506
approved these changes
Jul 17, 2023
0inn
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코멘트가 좀 늦어서 죄송합니다 . .
궁금한 점이랑 리뷰 달아뒀어요 ! 고생하셨습니다 👍🏻
enebin
force-pushed
the
feature/network-module
branch
from
July 18, 2023 01:04
eb932d3
to
68c8c05
Compare
enebin
force-pushed
the
feature/network-module
branch
from
July 18, 2023 10:49
4936e26
to
877a61e
Compare
enebin
force-pushed
the
feature/network-module
branch
from
July 18, 2023 11:03
877a61e
to
62ac019
Compare
0inn
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굳 ! 확인 완 :)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADDED
KeymeAPIManager
KeymeAPIManager
테스트사용(수정)
API 요청
statusCode
를 지원할지는 미정인증토큰 추가하기
참고
더 참고
APIRequestable
이라는 레이어로 추가함object: TestItem.self
를 안 해도 깔쌈하게 돌아가게끔 하려고 했으나 JSON과struct
가 반드시 1대 1 매칭이 아닐 수 있다는 생각이 들어서 일단 보류써보고 영 거지같으면 그때그때 수정할게요.. API 나오면 한 번쯤 엎어야될 것 같은데 지금 뭐 타이트하게 해봤자 나중에 할 일만 늘어날 듯ㅋㅋ