Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(tokenfactory): 1: State transitions, collections, genesis import and export, and app wiring #1596

Merged
merged 8 commits into from
Sep 25, 2023
Merged

feat(tokenfactory): 1: State transitions, collections, genesis import and export, and app wiring #1596

merged 8 commits into from
Sep 25, 2023

Conversation

Unique-Divine
Copy link
Member

@Unique-Divine Unique-Divine commented Sep 21, 2023 •
edited
Loading

@Unique-Divine Unique-Divine changed the title epic(tokenfactory): State transitions, collections, genesis import and export, and app wiring feat(tokenfactory): #1: State transitions, collections, genesis import and export, and app wiring Sep 21, 2023
@Unique-Divine Unique-Divine changed the title feat(tokenfactory): #1: State transitions, collections, genesis import and export, and app wiring feat(tokenfactory): [1] State transitions, collections, genesis import and export, and app wiring Sep 21, 2023
@Unique-Divine Unique-Divine changed the title feat(tokenfactory): [1] State transitions, collections, genesis import and export, and app wiring feat(tokenfactory): ① State transitions, collections, genesis import and export, and app wiring Sep 21, 2023
@Unique-Divine Unique-Divine changed the title feat(tokenfactory): ① State transitions, collections, genesis import and export, and app wiring feat(tokenfactory): 1: State transitions, collections, genesis import and export, and app wiring Sep 21, 2023
@Unique-Divine Unique-Divine marked this pull request as ready for review September 21, 2023 14:38
@Unique-Divine Unique-Divine requested a review from a team as a code owner September 21, 2023 14:38
@Unique-Divine
Squashed merge from branch: realu/ci-coverage-not-reporting
2cd485d 
commit 72094e8
Author: Unique-Divine <realuniquedivine@gmail.com>
Date:   Thu Sep 21 13:55:31 2023 -0500

    refactor(test.mk): add comment to NOTE the issue with using the verbose flag

commit c15d8cf
Author: Unique-Divine <realuniquedivine@gmail.com>
Date:   Thu Sep 21 13:38:57 2023 -0500

    chore: rn gofumpt formatter cause change and run CI

commit e37aa94
Author: Unique-Divine <realuniquedivine@gmail.com>
Date:   Thu Sep 21 13:34:51 2023 -0500

    ci: disable verbose flag #wip

commit cb56178
Author: Unique-Divine <realuniquedivine@gmail.com>
Date:   Thu Sep 21 13:30:41 2023 -0500

    ci: try removing flags to make reports publish
@codecov
Copy link

codecov bot commented Sep 21, 2023 •
edited
Loading

Codecov Report

Merging #1596 (274eda6) into master (0f2169e) will increase coverage by 0.18%.
Report is 13 commits behind head on master.
The diff coverage is 76.70%.

@@            Coverage Diff             @@
##           master    #1596      +/-   ##
==========================================
+ Coverage   70.77%   70.95%   +0.18%     
==========================================
  Files         180      186       +6     
  Lines       14786    14493     -293     
==========================================
- Hits        10465    10284     -181     
+ Misses       3645     3558      -87     
+ Partials      676      651      -25
Files Changed Coverage
app/app.go ø
x/common/asset/pair.go ø
x/devgas/v1/types/codec.go ø
x/epochs/types/identifier.go ø
x/perp/v2/keeper/calc.go ø
x/perp/v2/keeper/twap.go ø
x/tokenfactory/types/genesis.go 0.00%
x/perp/v2/module/abci.go 28.57%
x/tokenfactory/keeper/grpc_query.go 28.57%
x/perp/v2/module/genesis.go 62.50%
... and 25 more

matthiasmatt
matthiasmatt approved these changes Sep 22, 2023
View reviewed changes
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 61 Code Smells

No Coverage information No Coverage information
22.2% 22.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Unique-Divine Unique-Divine merged commit e95f331 into master Sep 25, 2023
@Unique-Divine Unique-Divine deleted the realu/tf-0 branch September 25, 2023 13:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@matthiasmatt matthiasmatt matthiasmatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Unique-Divine @matthiasmatt