Crashing on OFX import

[VeraStray]

I just installed Denaro. It is crashing when I try to import OFX. I am on Fedora 37 Gnome 43.3. No error message. Just closes and I have to re-launch. I tried importing CSV as well and it just says 0 transactions imported. I have confirmed the CSV file is not empty.

[fsobolev]

I tried importing CSV as well and it just says 0 transactions imported. I have confirmed the CSV file is not empty.

A CSV file not created in Denaro is expected to give "0 transactions imported" result. From user documentation:

While CSV is a common format and some banks allow their users to export information as CSV, these files are in fact tables that can contain arbitrary data. Importing a CSV file created in other program will fail, because its data will not be compatible with what Denaro tries to get from a file. The purpose of CSV import/export is to provide a way to add data to an account using external programs such as text editors and office suites. Import will only add new transactions without overriding existing ones.

But crash on OFX import is definitely a bug. Could you please run the app in terminal and copy the output? If installed using flatpak, you can use this command:

flatpak run org.nickvision.money

[VeraStray]

Thanks for the quick reply. Here is the terminal output after opening and trying to import...

[leira@leira ~]$ flatpak run org.nickvision.money

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 11:18:20.224: gtk_widget_get_parent: assertion 'GTK_IS_WIDGET (widget)' failed

(NickvisionMoney.GNOME:2): Gtk-CRITICAL **: 11:18:20.224: gtk_widget_add_css_class: assertion 'GTK_IS_WIDGET (widget)' failed
Registering new type NickvisionMoneyGNOMEControlsGroupRow with parent AdwActionRow
Unhandled exception. OfxSharp.OFXParseException: OFX security unsupported
at OfxSharp.OFXDocumentParser.CheckHeader(String[] header)
at OfxSharp.OFXDocumentParser.ParseHeader(String file)
at OfxSharp.OFXDocumentParser.SGMLToXML(String file)
at OfxSharp.OFXDocumentParser.ParseOfxDocument(String ofxString)
at OfxSharp.OFXDocumentParser.Import(String ofx)
at OfxSharp.OFXDocumentParser.Import(FileStream stream)
at NickvisionMoney.Shared.Models.Account.ImportFromOFXAsync(String path, String rgba) in /run/build/org.nickvision.money/NickvisionMoney.Shared/Models/Account.cs:line 1279
at NickvisionMoney.Shared.Models.Account.ImportFromFileAsync(String path, String rgba) in /run/build/org.nickvision.money/NickvisionMoney.Shared/Models/Account.cs:line 1089
at NickvisionMoney.Shared.Controllers.AccountViewController.ImportFromFileAsync(String path) in /run/build/org.nickvision.money/NickvisionMoney.Shared/Controllers/AccountViewController.cs:line 893
at NickvisionMoney.GNOME.Views.AccountView.<>c__DisplayClass88_1.<b__1>d.MoveNext() in /run/build/org.nickvision.money/NickvisionMoney.GNOME/Views/AccountView.cs:line 867
--- End of stack trace from previous location ---
at NickvisionMoney.GNOME.Views.AccountView.<>c__DisplayClass88_0.<b__0>d.MoveNext() in /run/build/org.nickvision.money/NickvisionMoney.GNOME/Views/AccountView.cs:line 867
--- End of stack trace from previous location ---
at System.Threading.Tasks.Task.<>c.b__128_1(Object state)
at System.Threading.ThreadPoolWorkQueue.Dispatch()
at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart()
[leira@leira ~]$

[nlogozzo]

Could you attach the ofx file you tried importing? (Remove any important information from the file) Its seems as the ofx library had trouble parsing the file and I'd like to make sure it's formatted correctly or atleast update Denaro to match your file's format.

[nlogozzo]

By the looks of the error message, is the ofx file encrypted in any way? Password-protected?

[VeraStray]

It's not encrypted or password-protected. Is there a way I can send it to you in a less public way?

This is the start of the file:
OFXHEADER:100
DATA:OFXSGML
VERSION:102
SECURITY:TYPE1
ENCODING:USASCII
CHARSET:1252
COMPRESSION:NONE
OLDFILEUID:NONE
NEWFILEUID:NONE

[nlogozzo]

You can email it to me: nlogozzo225@gmail.com

Like I said feel free to replace sensitive amounts and descriptions with garbage data.

[ascpial]

As this issue is related to imports, I should mention than QIF import is broken as well.

I tried to import data from an other app, HomeBank, as well as the example file given in #265 and the toaster says "0 transactions imported".

The format of the date in both files is correct (US date: MM/DD/YYYY).

I'm using the latest version at the time of writing, which is 2023.2.2.

There is also no output in console when launching the app from the terminal.

[nlogozzo]

@ascpial Could you also attach here or email me a sample QIF file that you are using?

[nlogozzo]

@VeraStray it turns out that your issue is rather quite easy to fix. It's not Denaro's fault.
You just have to change the security line in your OFX file from TYPE1 to NONE.
See: https://support.cosmolex.com/knowledge-base/statement-import-error-ofx-security-unsupported/

I did however commit a fix that won't crash the whole program when ofx import fails, but say 0 transactions imported

@fsobolev Could we add something to docs for OFX that says make sure the security line is NONE and not TYPE1?

[nlogozzo]

@ascpial Since QIF is different from OFX, open another issue with your QIF file attached so we can fix that there.

[fsobolev]

@fsobolev Could we add something to docs for OFX that says make sure the security line is NONE and not TYPE1?

Or we could make Denaro parse ofx file to check if it contains security TYPE1 and if it does, create new temporary file with replaced security value and pass this file to OFXSharp.

[nlogozzo]

Or we could make Denaro parse ofx file to check if it contains security TYPE1 and if it does, create new temporary file with replaced security value and pass this file to OFXSharp.

Yeah, i guess we can do that. I'll implement it now :)

[nlogozzo]

#369 Will check for and handle the security automatically, so @VeraStray no need to make changes to your file. I'll make a beta release later today/tomorrow so that you can test the fix.

[VeraStray]

@nlogozzo That's awesome! Thanks for this!

[nlogozzo]

https://github.com/nlogozzo/NickvisionMoney/releases/tag/2023.3.0-beta2

[VeraStray]

It works Nick! I didn't make any change to the OFX file as you suggested. No issues. Thanks for your work on this! I have a couple ideas for future development. Hope you don't mind me sharing.... I suspect you are working on some of these already. Reports are the main thing. To be able to find out how much was spent in a specific group over a specific period. The ability to see what group a transaction is in from the main list of transactions. Maybe a more streamlined way to assign groups faster. But as I said, just the ability to get some totals from groups and periods is my main need, so I know how much we are spending on groceries, etc... Thanks for your amazing work! ------- Original Message -------

…

On Wednesday, March 15th, 2023 at 10:21 PM, Nick Logozzo ***@***.***> wrote: https://github.com/nlogozzo/NickvisionMoney/releases/tag/2023.3.0-beta2 — Reply to this email directly, [view it on GitHub](#342 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AP2VIYNE2OO2ZWAF6IAD2KDW4KBLJANCNFSM6AAAAAAVNUT4SE). You are receiving this because you were mentioned.Message ID: ***@***.***>

[fsobolev]

Reports are the main thing. To be able to find out how much was spent in a specific group over a specific period.
<...>
But as I said, just the ability to get some totals from groups and periods is my main need, so I know how much we are spending on groceries, etc...

#366, #367 and #289 are probably what you are interested in.

The ability to see what group a transaction is in from the main list of transactions.

I don't think there's a good way to place group label in transaction rows in current design. But I hope you will find #339 useful for your needs