Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

PR for Issue #20 where macOS 14+ screenshot filenames don't save because of narrow space #21

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

brentmartinmiller
Copy link

Modified rename function to replace narrow spaces with spaces.

Issue #20

Copy link
Owner

@NicolasCARPi NicolasCARPi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution!

@brentmartinmiller
Copy link
Author

You're welcome. So are you the primary developer for the plugin now?

@NicolasCARPi NicolasCARPi merged commit a85a02f into NicolasCARPi:master Oct 29, 2024
2 checks passed
@NicolasCARPi
Copy link
Owner

So are you the primary developer for the plugin now?

Yeah. I proposed my help to original author but he never answered. So I forked it and started merging open PR (first one was actually mine). I'm using it in my app and don't like unmaintained dependencies, so here I am.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants