Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add custom user #2

Open
dgladkov opened this issue Jul 13, 2015 · 1 comment
Open

Add custom user #2

dgladkov opened this issue Jul 13, 2015 · 1 comment

Comments

@dgladkov
Copy link

  1. Modifying and vendoring existing reusable apps and libraries without a good reason is a bad practice.
  2. See https://docs.djangoproject.com/en/1.8/topics/auth/customizing/#specifying-a-custom-user-model about creating a custom user with email as username. Custom model should be just the same as a default one, but email should have unique constraint and username field should be removed completely
  3. Django-registration should work out of the box correctly because it reuses django.contrib.auth form logic.
@NikolayBorovenskiy
Copy link
Owner

Hello, Dmitry!
Thank you for your comments on the tests. This is very helpful for me. Thank
you for taking the time.
I changed the structure of the repository, adding files db.sqlite3 and
requirements.tht ~ to gitignore.
In a second comment, I read about a custom-user-model, learned a lot. Tell
me,do I need to fix the test project using BaseUserManager, AbstraktBaseOser
or the remark for the future?
If fix, it will be necessary to refuse the applications Register and create
my ...
Sincerely, Nicholay Borovensky.

2015-07-13 18:19 GMT+03:00 Dmitry Gladkov notifications@github.com:

  1. Modifying and vendoring existing reusable apps and libraries
    without a good reason is a bad practice.
  2. See
    https://docs.djangoproject.com/en/1.8/topics/auth/customizing/#specifying-a-custom-user-model
    about creating a custom user with email as username. Custom model should be
    just the same as a default one, but email should have unique
    constraint and username field should be removed completely
  3. Django-registration should work out of the box correctly because it
    reuses django.contrib.auth form logic.


Reply to this email directly or view it on GitHub
#2.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants