Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

🤩 Multiple Image Picker V.2.0 Release 🚀 #180

Merged
merged 75 commits into from
Dec 13, 2024
Merged
Changes from 1 commit
Commits
Show all changes
75 commits
Select commit Hold shift + click to select a range
cce00e1
✨ feat: convert to HXPhotoPicker && using nitro module
baronha Oct 23, 2024
de1b9d7
✨ feat: doing nitro modules
baronha Oct 23, 2024
ee63bb3
✨ feat: add editor for picker
baronha Oct 24, 2024
e099257
✨ feat: done iOS
baronha Oct 24, 2024
db8afbd
✨ feat: config nitro on Android still very very bugs
baronha Oct 26, 2024
56c5e65
✨ migrate to com.margelo.nitro.multipleimagepicker
baronha Oct 27, 2024
d24cbf7
🐛 bug: .R on Android
baronha Oct 27, 2024
48e4d12
✨ feat: upgrade nitro modules 0.14.0
baronha Oct 30, 2024
fe83d76
✨ feat: upgrade nitro 0.17 && improve Picture Selector on Android
baronha Nov 27, 2024
9484dab
✨ feat: add more android
baronha Nov 28, 2024
5caab21
✨ feat: upgrade nitro 0.18 and add more drawable for android xml
baronha Nov 28, 2024
5be0f94
✨ feat: Add more option for Android and save status for asset
baronha Nov 28, 2024
09e8d7a
✨ feat: completed android
baronha Nov 29, 2024
f26d2d1
🐛 fix: handle empty selected
baronha Nov 29, 2024
267e74a
✨ feat: add /example
baronha Dec 2, 2024
a526143
✨ feat: upgrade nitro 0.18.1
baronha Dec 2, 2024
b92d6a4
✨ feat: handle selected assets
baronha Dec 3, 2024
a08b1de
♻️ refactor: remove originalPath
baronha Dec 3, 2024
de829aa
✨ feat: add light mode for iOS
baronha Dec 3, 2024
3159d21
✨ feat: Add button close light mode for iOS
baronha Dec 4, 2024
43753d4
✨ feat: custom more language for Android
baronha Dec 4, 2024
db04a71
♻️ refactor: convert to Language Code
baronha Dec 4, 2024
99b9cb8
♻️ refactor: remove max photo config
baronha Dec 4, 2024
e4d6d85
✨ feat: double check language
baronha Dec 4, 2024
f759ca8
✨ feat: add video quality on android
baronha Dec 4, 2024
dd2259c
✨ feat: add JSDoc for Typescript
baronha Dec 4, 2024
8b9161b
🐛 fix: solved conflict nitro type options
baronha Dec 5, 2024
b881413
✨ feat: Docusaurus
baronha Dec 5, 2024
39c1cf0
Merge pull request #173 from baronha/nitro
baronha Dec 5, 2024
9540401
✨ feat: adding docusaurus
baronha Dec 5, 2024
1358875
✨ feat: add config.mdx
baronha Dec 5, 2024
ad82858
✨ feat: add RESULT.mdx
baronha Dec 5, 2024
802afdf
✨ feat: doing add docs for getting started
baronha Dec 5, 2024
4505bda
✨ feat: migrate docs -> @gorhom/docusaurus-preset
baronha Dec 5, 2024
df9f484
✨ feat: add patch file for doc
baronha Dec 5, 2024
02a379f
🐛 fix: remove isShowAssetNumber option
baronha Dec 6, 2024
0134976
✨ feat: add more document
baronha Dec 6, 2024
52ba145
✨ feat: done /docs and refactor /example
baronha Dec 6, 2024
8f19472
✨ feat: add more component for /example
baronha Dec 6, 2024
c03d614
✨ feat: add more library for /example
baronha Dec 6, 2024
613b665
✨ feat: add more section /example
baronha Dec 6, 2024
e9db6ae
✨ feat: add more option for /example
baronha Dec 6, 2024
caf1c8f
✨ feat: add more option for /example
baronha Dec 7, 2024
1b7706f
✨ feat: add more option
baronha Dec 7, 2024
86aa84a
✨ feat: add minDuration for Android, add language on /example
baronha Dec 8, 2024
9232689
✨ feat: add minDuration, maxDuration
baronha Dec 8, 2024
7a98c6d
✨ feat: improve README
baronha Dec 9, 2024
ef54484
Update README.md
baronha Dec 9, 2024
31e4710
Update README.md
baronha Dec 9, 2024
309def8
feat: add video player document
baronha Dec 9, 2024
c2c50e8
✨ feat: deploy docs website
baronha Dec 9, 2024
ad5ea32
🚑 fix: document
baronha Dec 9, 2024
0362f9c
🚑 fix: Document Website
baronha Dec 9, 2024
dd12899
🚑 Fix: fix onPress Image /example
baronha Dec 9, 2024
40fbf0e
✨ feat: yarn instead of npm
baronha Dec 9, 2024
3ba760c
🚑 fix: base url docusaurus
baronha Dec 9, 2024
8fd06c6
🐛 fix: add README for example && fix document
baronha Dec 9, 2024
d2e8726
✨ feat: change editUrl
baronha Dec 9, 2024
d3cc6df
✨ feat: add more document
baronha Dec 9, 2024
8187c65
Merge pull request #183 from baronha/feature/open-crop
baronha Dec 9, 2024
604d85d
✨ feat: add custom crop ratio
baronha Dec 10, 2024
bed75ea
✨ feat: add more option for crop, ratio, default ratio for both platform
baronha Dec 11, 2024
9227ce5
✨ feat: add more option for crop, ratio, default ratio for both platform
baronha Dec 11, 2024
677b316
✨ feat: add check image for cropper
baronha Dec 11, 2024
3693506
Merge pull request #184 from baronha/feature/open-crop
baronha Dec 11, 2024
5297307
✨ feat: done open-crop
baronha Dec 11, 2024
a996d84
✨ feat: done handle preview on iOS
baronha Dec 12, 2024
c34170f
✨ feat: done open preview on Android
baronha Dec 12, 2024
f0b513e
♻️ refactor: change params openPreview | improve GIF on iOS
baronha Dec 12, 2024
ec5ba02
✨ feat: add doc for Preview
baronha Dec 12, 2024
9359353
Merge pull request #186 from baronha/feature/open-preview
baronha Dec 12, 2024
e50038b
⏪ fix: Lost code on Preview Android
baronha Dec 12, 2024
f6a44ab
♻️ refactor: remove compress when picker -> Too Slow
baronha Dec 13, 2024
b3244ef
✨ feat: add camera config, remove allowedCamera props
baronha Dec 13, 2024
c7bd60e
✨ feat: release 2.0.0
baronha Dec 13, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
✨ feat: upgrade nitro 0.18.1
  • Loading branch information
baronha committed Dec 2, 2024
commit a526143089fc95791f08f431f4f946298d5c4875
6 changes: 5 additions & 1 deletion MultipleImagePicker.podspec
Original file line number Diff line number Diff line change
@@ -26,6 +26,7 @@ Pod::Spec.new do |s|
s.dependency "HXPhotoPicker/Editor/Lite", "4.2.3"

s.pod_target_xcconfig = {
# C++ compiler flags, mainly for folly.
"GCC_PREPROCESSOR_DEFINITIONS" => "$(inherited) FOLLY_NO_CONFIG FOLLY_CFG_NO_COROUTINES"
}

@@ -34,5 +35,8 @@ Pod::Spec.new do |s|

add_nitrogen_files(s)

s.dependency 'React-jsi'
s.dependency 'React-callinvoker'

install_modules_dependencies(s)
end
end
3 changes: 3 additions & 0 deletions example/app.json
Original file line number Diff line number Diff line change
@@ -33,6 +33,9 @@
[
"expo-build-properties",
{
"ios": {
// "useFrameworks": "static"
},
"android": {
"compileSdkVersion": 34,
"targetSdkVersion": 34,
2 changes: 1 addition & 1 deletion example/package.json
Original file line number Diff line number Diff line change
@@ -27,7 +27,7 @@
"@react-native/typescript-config": "0.75.2",
"@types/react": "~18.2.45",
"react-native-builder-bob": "^0.30.0",
"react-native-nitro-modules": "0.18.0",
"react-native-nitro-modules": "0.18.1",
"typescript": "^5.1.3"
},
"private": true
4 changes: 3 additions & 1 deletion example/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
{
"compilerOptions": {},
"compilerOptions": {
"outDir": "./lib"
},
"extends": "../tsconfig"
}
8 changes: 4 additions & 4 deletions example/yarn.lock
Original file line number Diff line number Diff line change
@@ -6174,10 +6174,10 @@ react-native-builder-bob@^0.30.0:
which "^2.0.2"
yargs "^17.5.1"

react-native-nitro-modules@0.18.0:
version "0.18.0"
resolved "https://registry.yarnpkg.com/react-native-nitro-modules/-/react-native-nitro-modules-0.18.0.tgz#62f30088f370cd922e122e2dd64ca8fbca94e241"
integrity sha512-jhZdI1TduCb/1bXlV6rJLPQ1+bvoMQDkF+fRnxnD8az7grjqLj9WIdLEveIgtSArZkzK8WVknddyK7KthQXrbw==
react-native-nitro-modules@0.18.1:
version "0.18.1"
resolved "https://registry.yarnpkg.com/react-native-nitro-modules/-/react-native-nitro-modules-0.18.1.tgz#2d0f695b5a5a6f1be87da158868c3ea984be5989"
integrity sha512-F1PA92N8Qv/0I3gKnUFU/eP2C16TSSWwuWuUJnVXX4pCrZztP6BHSvRAZj9WpwxytoKICjwgeVk8K//kvZDZAg==

react-native@0.75.0:
version "0.75.0"
8 changes: 5 additions & 3 deletions ios/HybridMultipleImagePicker+Result.swift
Original file line number Diff line number Diff line change
@@ -22,7 +22,7 @@ extension HybridMultipleImagePicker {
return ""
}()

let type: ResultType? = .init(fromString: asset.mediaType == .video ? "video" : "image") ?? nil
// let type: ResultType? = .init(fromString: asset.mediaType == .video ? "video" : "image") ?? nil
let thumbnail = asset.phAsset?.getVideoThumbnail(from: url.absoluteString, in: 1)

return Result(path: url.absoluteString,
@@ -34,10 +34,12 @@ extension HybridMultipleImagePicker {
size: Double(asset.fileSize),
bucketId: nil,
realPath: nil,
originalPath: url.absoluteString,
parentFolderName: nil,
creationDate: creationDate > 0 ? Double(creationDate) : nil,
type: type,
// type: type,
duration: asset.videoDuration,
thumbnail: thumbnail)
thumbnail: thumbnail,
crop: false)
}
}
1 change: 1 addition & 0 deletions ios/HybridMultipleImagePicker.swift
Original file line number Diff line number Diff line change
@@ -84,6 +84,7 @@ class HybridMultipleImagePicker: HybridMultipleImagePickerSpec {
group.enter()

let urlResult = try await response.urlResult(compression)

let resultData = self.getResult(response, urlResult.url)

data.append(resultData)
Original file line number Diff line number Diff line change
@@ -70,6 +70,9 @@ namespace MultipleImagePicker { class HybridMultipleImagePickerSpecCxx; }
// This header is generated by Xcode/Swift on every app build.
// If it cannot be found, make sure the Swift module's name (= podspec name) is actually "MultipleImagePicker".
#include "MultipleImagePicker-Swift.h"
// Same as above, but used when building with frameworks (`use_frameworks`)
#elif __has_include(<MultipleImagePicker/MultipleImagePicker-Swift.h>)
#include <MultipleImagePicker/MultipleImagePicker-Swift.h>
#else
#error MultipleImagePicker's autogenerated Swift header cannot be found! Make sure the Swift module's name (= podspec name) is actually "MultipleImagePicker", and try building the app first.
#endif
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -62,12 +62,12 @@
"eslint": "^8.57.0",
"eslint-config-prettier": "^9.1.0",
"eslint-plugin-prettier": "^5.2.1",
"nitro-codegen": "0.18.0",
"nitro-codegen": "0.18.1",
"prettier": "^3.3.3",
"react": "^18.3.1",
"react-native": "^0.75.2",
"react-native-builder-bob": "^0.30.0",
"react-native-nitro-modules": "0.18.0",
"react-native-nitro-modules": "0.18.1",
"typescript": "^5.5.4"
},
"peerDependencies": {
1 change: 1 addition & 0 deletions tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"compilerOptions": {
"baseUrl": ".",
"outDir": "./lib",
"paths": {
"@baronha/react-native-multiple-image-picker": ["src"]
},
18 changes: 9 additions & 9 deletions yarn.lock
Original file line number Diff line number Diff line change
@@ -4557,13 +4557,13 @@ neo-async@^2.5.0:
resolved "https://registry.yarnpkg.com/neo-async/-/neo-async-2.6.2.tgz#b4aafb93e3aeb2d8174ca53cf163ab7d7308305f"
integrity sha512-Yd3UES5mWCSqR+qNT93S3UoYUkqAZ9lLg8a7g9rimsWmYGK8cVToA4/sF3RrshdyV3sAGMXVUmpMYOw+dLpOuw==

nitro-codegen@0.18.0:
version "0.18.0"
resolved "https://registry.yarnpkg.com/nitro-codegen/-/nitro-codegen-0.18.0.tgz#3928378613b23959a24c8b4e76cb58d730b037a7"
integrity sha512-ltYEo7BRD32GVim0Ta/UIygxe5pGM4fXSqHUpHoJMni4CW77rwJB5ZjbgtL5r3qibC6aUM0ATRKtYwyvaCG0lw==
nitro-codegen@0.18.1:
version "0.18.1"
resolved "https://registry.yarnpkg.com/nitro-codegen/-/nitro-codegen-0.18.1.tgz#5f04829fda54028b5832f35abc432e577530b7c1"
integrity sha512-gDOHIIFFY89Ibo/Q8Dlzx4Rk9fCaGnby4Er5Dh1xV4J5hMqTfqo2VjG+RxScdUTYy/SKOc0UsB2faQybs5+GDw==
dependencies:
chalk "^5.3.0"
react-native-nitro-modules "^0.18.0"
react-native-nitro-modules "^0.18.1"
ts-morph "^24.0.0"
yargs "^17.7.2"
zod "^3.23.8"
@@ -5074,10 +5074,10 @@ react-native-builder-bob@^0.30.0:
which "^2.0.2"
yargs "^17.5.1"

react-native-nitro-modules@0.18.0, react-native-nitro-modules@^0.18.0:
version "0.18.0"
resolved "https://registry.yarnpkg.com/react-native-nitro-modules/-/react-native-nitro-modules-0.18.0.tgz#62f30088f370cd922e122e2dd64ca8fbca94e241"
integrity sha512-jhZdI1TduCb/1bXlV6rJLPQ1+bvoMQDkF+fRnxnD8az7grjqLj9WIdLEveIgtSArZkzK8WVknddyK7KthQXrbw==
react-native-nitro-modules@0.18.1, react-native-nitro-modules@^0.18.1:
version "0.18.1"
resolved "https://registry.yarnpkg.com/react-native-nitro-modules/-/react-native-nitro-modules-0.18.1.tgz#2d0f695b5a5a6f1be87da158868c3ea984be5989"
integrity sha512-F1PA92N8Qv/0I3gKnUFU/eP2C16TSSWwuWuUJnVXX4pCrZztP6BHSvRAZj9WpwxytoKICjwgeVk8K//kvZDZAg==

react-native@^0.75.2:
version "0.75.4"