feat: Implement Display for enums
#33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiktor-k
added a commit
to wiktor-k/openapi-generator
that referenced
this pull request
Sep 18, 2024
Rust docs for `ToString` explicitly recommend implementing `Display`: > This trait is automatically implemented for any type which implements the Display trait. As such, ToString shouldn’t be implemented directly: Display should be implemented instead, and you get the ToString implementation for free. See: https://doc.rust-lang.org/std/string/trait.ToString.html See: Nitrokey/nethsm-sdk-rs#33 Signed-off-by: Wiktor Kwapisiewicz <wiktor@metacode.biz>
5 tasks
Fixes: Nitrokey#32 Signed-off-by: Wiktor Kwapisiewicz <wiktor@metacode.biz>
robin-nitrokey
force-pushed
the
wiktor/implement-display
branch
from
7efb9df to
1e8519c
Compare
|
Thank you! |
wiktor-k
added a commit
to wiktor-k/openapi-generator
that referenced
this pull request
Sep 23, 2024
Rust docs for `ToString` explicitly recommend implementing `Display`: > This trait is automatically implemented for any type which implements the Display trait. As such, ToString shouldn’t be implemented directly: Display should be implemented instead, and you get the ToString implementation for free. See: https://doc.rust-lang.org/std/string/trait.ToString.html See: Nitrokey/nethsm-sdk-rs#33 Signed-off-by: Wiktor Kwapisiewicz <wiktor@metacode.biz>
wing328
pushed a commit
to OpenAPITools/openapi-generator
that referenced
this pull request
Sep 24, 2024
Rust docs for `ToString` explicitly recommend implementing `Display`: > This trait is automatically implemented for any type which implements the Display trait. As such, ToString shouldn’t be implemented directly: Display should be implemented instead, and you get the ToString implementation for free. See: https://doc.rust-lang.org/std/string/trait.ToString.html See: Nitrokey/nethsm-sdk-rs#33 Signed-off-by: Wiktor Kwapisiewicz <wiktor@metacode.biz>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the template and run
update_openapi.sh.It should make it easier for Rust devs a bit. Please test as I'm not that familiar with openapi-generator (it does compiles and renders nice docs though).
(btw, I've also locally used
podmaninstead ofdockerwhich has a nice effect of not having to require a docker daemon)Fixes: #32