Skip to content

Commit

Permalink
Merge pull request #169888 from bobby285271/packagekit
Browse files Browse the repository at this point in the history
packagekit: fix build with Nix 2.8
  • Loading branch information
bobby285271 authored Apr 28, 2022
2 parents 4ae1684 + 797898a commit c254860
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 11 deletions.
12 changes: 2 additions & 10 deletions pkgs/tools/package-management/packagekit/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
, vala
, gtk-doc
, nix
, nlohmann_json ? null
, boost
, meson
, ninja
Expand All @@ -27,12 +26,6 @@
, enableSystemd ? stdenv.isLinux
, systemd
}:
let
nix_version = lib.removeSuffix nix.VERSION_SUFFIX nix.version;
useNlohmann = lib.versionAtLeast "2.7" nix_version;
in

assert useNlohmann -> nlohmann_json != null;

stdenv.mkDerivation rec {
pname = "packagekit";
Expand All @@ -43,8 +36,8 @@ stdenv.mkDerivation rec {
src = fetchFromGitHub {
owner = "PackageKit";
repo = "PackageKit";
rev = "33b847c49b4a42499e3c0f10fef62830c874e086";
sha256 = "UDpMswf0EBwcoHTqoWiztXnIAwM69nM+S9MPsR24amw=";
rev = "30bb82da8d4161330a6d7a20c9989149303421a1";
sha256 = "k2osc2v0OuGrNjwxdqn785RsbHEJP3p79PG9YqnVE3U=";
};

buildInputs = [
Expand All @@ -59,7 +52,6 @@ stdenv.mkDerivation rec {
nix
boost
] ++ lib.optional enableSystemd systemd
++ lib.optional useNlohmann nlohmann_json
++ lib.optional enableBashCompletion bash-completion;
nativeBuildInputs = [
vala
Expand Down
2 changes: 1 addition & 1 deletion pkgs/top-level/all-packages.nix
Original file line number Diff line number Diff line change
Expand Up @@ -9056,7 +9056,7 @@ with pkgs;

p7zip = callPackage ../tools/archivers/p7zip { };

packagekit = callPackage ../tools/package-management/packagekit { nix = nixVersions.nix_2_6; };
packagekit = callPackage ../tools/package-management/packagekit { nix = nixVersions.nix_2_8; };

packetdrill = callPackage ../tools/networking/packetdrill { };

Expand Down

0 comments on commit c254860

Please # to comment.