Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

electron update script broken #321490

Closed
yayayayaka opened this issue Jun 21, 2024 · 5 comments · Fixed by #326364
Closed

electron update script broken #321490

yayayayaka opened this issue Jun 21, 2024 · 5 comments · Fixed by #326364
Labels
0.kind: bug Something is broken

Comments

@yayayayaka
Copy link
Member

Describe the bug

The electron update.py script depends on nix-universal-prefetch, which was removed by 578d7e7 in #321436.

Steps To Reproduce

Steps to reproduce the behavior:

  1. cd pkgs/development/tools/electron/update.py; ./update.py update-all

Expected behavior

The update scripts succeeds.

Notify maintainers

(myself)

Add a 👍 reaction to issues you find important.
@yayayayaka yayayayaka added the 0.kind: bug Something is broken label Jun 21, 2024
@Lassulus
Copy link
Member

sounds like we probably should readd nix-universal-prefetch?

@DieracDelta
Copy link
Member

Given the repo is removed, I don't think we can without reimplementing.

@tomfitzhenry
Copy link
Contributor

tomfitzhenry commented Jun 23, 2024 •
edited
Loading

https://github.com/Marcus-Arcadius/nix-universal-prefetch has an up-to-date (v0.4) fork.

I've raised https://github.com/orgs/nix-community/discussions/1321 to discuss nix-community ownership of this.

@tomfitzhenry
Copy link
Contributor

See #322179 for an example PR of migrating from nix-universal-prefetch to nix-update. Could this be done for electron?

@teutat3s
Copy link
Member

#326215

squalus added a commit to squalus/nixpkgs that referenced this issue Jul 11, 2024
@squalus
nix-universal-prefetch: init at 0.4.0
6757561 
This package was deleted in 578d7e7. This broke the Electron
update script.

This fixes the Electron update script.

Fixes NixOS#321490
squalus added a commit to squalus/nixpkgs that referenced this issue Jul 11, 2024
@squalus
electron: fix update script
210b11b 
The nix-universal-prefetch package was deleted in 578d7e7. Switch to
nurl.

Fixes NixOS#321490
@squalus squalus mentioned this issue Jul 11, 2024
Merged
13 tasks
shahinism pushed a commit to shahinism/nixpkgs that referenced this issue Jul 15, 2024
@squalus @shahinism
electron: fix update script
9bac754 
The nix-universal-prefetch package was deleted in 578d7e7. Switch to
nurl.

Fixes NixOS#321490
yayayayaka pushed a commit that referenced this issue Jul 25, 2024
@squalus @yayayayaka
electron: fix update script
11eb024 
The nix-universal-prefetch package was deleted in 578d7e7. Switch to
nurl.

Fixes #321490

(cherry picked from commit 3ff51e1)
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
0.kind: bug Something is broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

electron: fix update script squalus/nixpkgs
5 participants
@tomfitzhenry @Lassulus @teutat3s @DieracDelta @yayayayaka