Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

qemu: add meta.mainProgram #153425

Merged
merged 1 commit into from
Jan 4, 2022
Merged

qemu: add meta.mainProgram #153425

merged 1 commit into from
Jan 4, 2022

Conversation

PedroRegisPOAR
Copy link
Contributor

Motivation for this change

Using the nix cli with flakes it should be possible to not get a error message when the following command is ran:

nix run nixpkgs#qemu -- --version

Produces this error:

error: unable to execute '/nix/store/vfyx7mmb2q3csw1qphdcmfpx85d59jpm-qemu-6.1.0/bin/qemu': No such file or directory

Expected something like:

QEMU emulator version 6.1.0
Copyright (c) 2003-2021 Fabrice Bellard and the QEMU Project developers
Things done

Just added mainProgram = "qemu-kvm"; to meta and it works 🎉 🚀

Tested with:

nix run github:PedroRegisPOAR/nixpkgs/nixpkgs-unstable#qemu -- --version
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@bobby285271 bobby285271 changed the base branch from nixpkgs-unstable to master January 4, 2022 02:47
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 4, 2022
@PedroRegisPOAR
Copy link
Contributor Author

Waiting for end of:

TO_NIXPKGS_CLONE="~/some-folder"
mkdir -pv "$TO_NIXPKGS_CLONE" \
&& nix flake clone github:PedroRegisPOAR/nixpkgs/nixpkgs-unstable --dest "$TO_NIXPKGS_CLONE" \
&& cd "$TO_NIXPKGS_CLONE" \
&& nix run nixpkgs#nixpkgs-review pr 153425

@thiagokokada
Copy link
Contributor

Please fix the commit message:

qemu: add meta.mainProgram

@thiagokokada
Copy link
Contributor

@ofborg eval

@PedroRegisPOAR
Copy link
Contributor Author

Not sure I corrected the message right. I used GitKraken (UI) way to use git, so it allowed me to change the commit and pull before push, so it has a "merge commit" too 🤔

@thiagokokada
Copy link
Contributor

thiagokokada commented Jan 4, 2022

Not sure I corrected the message right. I used GitKraken (UI) way to use git, so it allowed me to change the commit and pull before push, so it has a "merge commit" too thinking

Yeah, definitively looks wrong. You should have only your commit here.

Also, there is 3 commits. Your old commit with the old commit message is still here.

@PedroRegisPOAR
Copy link
Contributor Author

Hope it is fixed now.

Not sure I corrected the message right. I used GitKraken (UI) way to use git, so it allowed me to change the commit and pull before push, so it has a "merge commit" too thinking

Yeah, definitively looks wrong. You should have only your commit here.

Also, there is 3 commits. Your old commit with the old commit message is still here.

@thiagokokada thiagokokada changed the title Adds meta.mainProgram to QEMU to fix broken nix run nixpkgs#qemu -- --version qemu: add meta.mainProgram Jan 4, 2022
@thiagokokada thiagokokada merged commit c8104ef into NixOS:master Jan 4, 2022
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants