Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

kalibrate-rtl: unstable-2013-12-14 -> unstable-2022-02-02 #170703

Merged
merged 2 commits into from
Apr 28, 2022

Conversation

viraptor
Copy link
Contributor

Description of changes

Update to a more recent version. It includes darwin support as one of the features.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@viraptor
Copy link
Contributor Author

cc @bjornfor @markuskowa @etu (from gitlog)

Update the version and enable darwin support.
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Apr 28, 2022
@ofborg ofborg bot requested a review from bjornfor April 28, 2022 00:40
@viraptor viraptor changed the title rtl-kalibrate: unstable-2013-12-14 -> unstable-2022-02-02 kalibrate-rtl: unstable-2013-12-14 -> unstable-2022-02-02 Apr 28, 2022
@takeda
Copy link
Contributor

takeda commented Apr 28, 2022

Result of nixpkgs-review pr 170703 run on x86_64-linux 1

1 package failed to build:
  • kalibrate-rtl

@takeda
Copy link
Contributor

takeda commented Apr 28, 2022

The package actually builds x86_64-linux with sandboxing enabled and I can run the command successfully with --help option, but for some reason it nixpkgs-review fails. It looks though that the failure is on my computer as it tries to download source code, it complains it can't write it. So the above comment can be ignored.

@markuskowa markuskowa merged commit dfc8b32 into NixOS:master Apr 28, 2022
@viraptor viraptor deleted the update-kalibrate branch May 2, 2022 13:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants