Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

gbl: fix aarch64-darwin build #175093

Merged
merged 1 commit into from
Jan 7, 2023
Merged

Conversation

raboof
Copy link
Member

@raboof raboof commented May 28, 2022

Description of changes

Compilation failed due to an old transitive dependency on 'ring',
briansmith/ring#1063.

fixes #175087

#zhfff

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 28, 2022
@raboof
Copy link
Member Author

raboof commented May 28, 2022

Result of nixpkgs-review pr 175093 run on x86_64-linux 1

1 package built:
  • gbl

@raboof raboof changed the title gbl: fix darwin-aarch64 build gbl: fix aarch64-darwin build May 28, 2022
@jiegec
Copy link
Contributor

jiegec commented Jul 6, 2022

Result of nixpkgs-review pr 175093 run on aarch64-darwin 1

1 package built:
  • gbl

@jiegec
Copy link
Contributor

jiegec commented Jul 6, 2022

Result of nixpkgs-review pr 175093 run on x86_64-darwin 1

1 package built:
  • gbl

@wegank
Copy link
Member

wegank commented Jan 4, 2023

I guess this should be rebased to remove

# never built on aarch64-darwin since first introduction in nixpkgs
broken = stdenv.isDarwin && stdenv.isAarch64;

Also, s/dac-gmbh/jonas-schievink/g.

Compilation failed due to an old transitive dependency on 'ring',
briansmith/ring#1063.
@raboof raboof force-pushed the gbl-fix-build-darwin-aarch64 branch from d48f7b6 to 1880157 Compare January 4, 2023 08:22
@raboof
Copy link
Member Author

raboof commented Jan 4, 2023

Result of nixpkgs-review pr 175093 run on x86_64-linux 1

1 package built:
  • gbl

@raboof
Copy link
Member Author

raboof commented Jan 4, 2023

I guess this should be rebased to remove

# never built on aarch64-darwin since first introduction in nixpkgs
broken = stdenv.isDarwin && stdenv.isAarch64;

Well-spotted, updated!

Also, s/dac-gmbh/jonas-schievink/g.

Thanks! Unfortunate that that archive is also archived already, but indeed I didn't find a more recent fork.

@raboof raboof merged commit cd215b4 into NixOS:master Jan 7, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gbl.aarch64-darwin:
4 participants