Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Pgadmin4: 8.3 -> 8.4, jsonformatter init at 0.3.2 #295860

Merged
merged 2 commits into from
Mar 17, 2024

Conversation

gador
Copy link
Member

@gador gador commented Mar 14, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

gador added 2 commits March 14, 2024 13:15
Signed-off-by: Florian Brandes <florian.brandes@posteo.de>
Signed-off-by: Florian Brandes <florian.brandes@posteo.de>
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 14, 2024
@risicle risicle added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Mar 17, 2024
@risicle
Copy link
Contributor

risicle commented Mar 17, 2024

This addresses CVE-2024-2044

Copy link
Contributor

@LeSuisse LeSuisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tests are passing and I played a bit with pgadmin4-desktopmode with no issue.

Result of nixpkgs-review pr 295860 run on x86_64-linux 1

8 packages built:
  • pgadmin4
  • pgadmin4-desktopmode
  • pgadmin4-desktopmode.dist
  • pgadmin4.dist
  • python311Packages.jsonformatter
  • python311Packages.jsonformatter.dist
  • python312Packages.jsonformatter
  • python312Packages.jsonformatter.dist

@LeSuisse LeSuisse merged commit 0bd32bf into NixOS:master Mar 17, 2024
28 checks passed
@LeSuisse
Copy link
Contributor

For 23.11 see #296624

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants