Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
cli-visualizer hasn't been working (at least for me with pulseaudio backend) since #28334. Downgrading to ncurses5 at least made it work somehow. There are still some weird artifacts though, with konsole, alacritty and maybe others, but not termite and probably xterm. The issue is the same as https://github.com/dpayne/cli-visualizer/issues/62. Wrapping the binary with TERM set to either
xterm-termite
orrxvt-256color
solves the issue for now (the latter of which I used here). See this comment.Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)