Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

amber-lang: init at 0.3.1-alpha #313774

Merged
merged 1 commit into from
May 23, 2024
Merged

amber-lang: init at 0.3.1-alpha #313774

merged 1 commit into from
May 23, 2024

Conversation

cafkafk
Copy link
Member

@cafkafk cafkafk commented May 22, 2024 •
edited
Loading

Description of changes

See also #313747

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

cafkafk
cafkafk commented May 22, 2024
View reviewed changes
Copy link
Member Author

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I may need to wrap this with BC, also seems like my patch contains some unnecessary formatting. Ultimately, should go upstream with this because expecting /bin/bash isn't really that nice, and we shouldn't need to patch this (maybe there are better solutions?)

isabelroses
isabelroses reviewed May 22, 2024
View reviewed changes
pkgs/by-name/am/amber-lang/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/am/amber-lang/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/am/amber-lang/package.nix Outdated Show resolved Hide resolved
@cafkafk cafkafk force-pushed the amber-lang-init-0.3.1-alpha branch from caf7093 to a7da0c6 Compare May 23, 2024 05:03
cafkafk
cafkafk commented May 23, 2024
View reviewed changes
Copy link
Member Author

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the patch out for a substituteInPlace, and wrapped the binary with bc. Also setup a simple passthru.tests so we have something to indicate if this breaks in the future, since we had to disable so many tests.

This is also fully ready for review now.

@cafkafk cafkafk force-pushed the amber-lang-init-0.3.1-alpha branch from a7da0c6 to 90791c8 Compare May 23, 2024 05:09
@cafkafk cafkafk requested a review from isabelroses May 23, 2024 05:09
@ofborg ofborg bot requested a review from uncenter May 23, 2024 06:04
@cafkafk cafkafk force-pushed the amber-lang-init-0.3.1-alpha branch from 90791c8 to 74d2e2d Compare May 23, 2024 11:59
@cafkafk
amber-lang: init at 0.3.1-alpha
a5a4793 
Signed-off-by: Christina Sørensen <christina@cafkafk.com>
@cafkafk cafkafk force-pushed the amber-lang-init-0.3.1-alpha branch from 74d2e2d to a5a4793 Compare May 23, 2024 12:01
@cafkafk cafkafk requested a review from Aleksanaa May 23, 2024 12:01
@cafkafk
Copy link
Member Author

cafkafk commented May 23, 2024 •
edited
Loading

Ready for review again, awesome we don't need to skip tests now :DD

@isabelroses isabelroses added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label May 23, 2024
@uncenter uncenter added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels May 23, 2024
@ofborg ofborg bot requested a review from uncenter May 23, 2024 12:49
@isabelroses isabelroses added 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people and removed 12.approvals: 2 This PR was reviewed and approved by two reputable people labels May 23, 2024
adamcstephens
adamcstephens approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@adamcstephens adamcstephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs on aarch64-darwin

@adamcstephens adamcstephens merged commit 3bea02f into NixOS:master May 23, 2024
25 of 27 checks passed
@cafkafk cafkafk deleted the amber-lang-init-0.3.1-alpha branch May 23, 2024 19:07
@isabelroses isabelroses mentioned this pull request May 27, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@adamcstephens adamcstephens adamcstephens approved these changes

@Aleksanaa Aleksanaa Aleksanaa approved these changes

@uncenter uncenter uncenter approved these changes

@isabelroses isabelroses isabelroses approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cafkafk @adamcstephens @Aleksanaa @uncenter @isabelroses