Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

invidious: move to by-name #355086

Merged
merged 1 commit into from
Nov 13, 2024
Merged

invidious: move to by-name #355086

merged 1 commit into from
Nov 13, 2024

Conversation

GaetanLepage
Copy link
Contributor

Things done

Changelog: https://github.com/iv-org/invidious/releases/tag/v2.20241110.0

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage
Copy link
Contributor Author

This line is failing since the move to by-name.

@ncfavier
Copy link
Member

This PR currently only has the move to by-name and not the actual update, right?

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 11, 2024
@GaetanLepage
Copy link
Contributor Author

This PR currently only has the move to by-name and not the actual update, right?

Yes exactly, I am stuck on adapting the script after this change.
Basically, nix-prefetch does not seem to work with the new location of the invidious package derivation.

@ncfavier
Copy link
Member

The nix-prefetch error seems to be unrelated to the by-name move; instead bisection points to #354367.

In the meantime, I suggest replacing the nix-prefetch call with

nix-prefetch fetchFromGitHub --owner iv-org --repo invidious --rev "$new_tag"

After that invidious updates successfully but the checkPhase fails.

@ncfavier ncfavier mentioned this pull request Nov 11, 2024
13 tasks
@pbsds
Copy link
Member

pbsds commented Nov 11, 2024

rather than block with a by-name migration, there is #355279 which is nearly ready to go

@GaetanLepage GaetanLepage changed the title invidious: 2.20240825.2 -> 2.20241110.0 invidious: move to by-name Nov 12, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 13, 2024
@GaetanLepage GaetanLepage merged commit 17767a5 into NixOS:master Nov 13, 2024
31 of 33 checks passed
@GaetanLepage GaetanLepage deleted the invidious branch November 13, 2024 13:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants