Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

prow: init unstable at 2019-08-14 #66662

Merged
merged 1 commit into from
Aug 16, 2019
Merged

prow: init unstable at 2019-08-14 #66662

merged 1 commit into from
Aug 16, 2019

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Aug 15, 2019 •
edited
Loading

Motivation for this change

Packaging up https://github.com/kubernetes/test-infra/tree/master/prow.

The included patch is also filed upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Aug 15, 2019
@kalbasit kalbasit added the 2.status: work-in-progress This PR isn't done label Aug 15, 2019
@kalbasit kalbasit changed the title mkpj: init at 2019-07-02 prow: init at 2019-08-14 Aug 15, 2019
@kalbasit kalbasit removed the 2.status: work-in-progress This PR isn't done label Aug 15, 2019
@kalbasit
Copy link
Member Author

@GrahamcOfBorg build prow

@kalbasit kalbasit marked this pull request as ready for review August 15, 2019 07:19
@kalbasit kalbasit changed the title prow: init at 2019-08-14 prow: init unstable at 2019-08-14 Aug 15, 2019
@kalbasit kalbasit merged commit 2cc2131 into NixOS:master Aug 16, 2019
@kalbasit kalbasit deleted the nixpkgs_add-mkpj branch August 16, 2019 03:48
@kalbasit kalbasit mentioned this pull request Aug 19, 2019
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kalbasit