-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
mpvScripts.sponsorblock: init #92507
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacien
commented
Jul 6, 2020
pacien
changed the title
mpvScripts.sponsorblock: init at f71e49e (2020-07-05)
[WIP] mpvScripts.sponsorblock: init
Jul 7, 2020
pacien
force-pushed
the
mpvscripts-sponsorblock-init
branch
2 times, most recently
from
July 14, 2020 11:30
6a7a82d
to
470130c
Compare
pacien
changed the title
[WIP] mpvScripts.sponsorblock: init
mpvScripts.sponsorblock: init
Jul 14, 2020
danielfullmer
suggested changes
Jul 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've built and tested this package briefly, with the suggested changes. It does seem to be working properly on the youtube videos I tried. Thanks!
pacien
force-pushed
the
mpvscripts-sponsorblock-init
branch
2 times, most recently
from
July 22, 2020 10:26
179ee4c
to
b7ebb43
Compare
danielfullmer
approved these changes
Jul 22, 2020
10 tasks
samuelgrf
reviewed
Jul 24, 2020
pacien
force-pushed
the
mpvscripts-sponsorblock-init
branch
from
July 26, 2020 20:01
b7ebb43
to
6b7c3f1
Compare
pacien
force-pushed
the
mpvscripts-sponsorblock-init
branch
from
August 7, 2020 12:47
6b7c3f1
to
1d18e35
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This creates a package for the sponsorblock mpv script.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)