Added option to have active users similar to standard forum software #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| if (widget.data.global) { | ||
| async.parallel({ | ||
| users: function(next) { | ||
| user.getUsersFromSet('users:online', 0, 49, next); |
There was a problem hiding this comment.
this already returns a list of user objects so no need to call getUserData again
dwendt
force-pushed
the
master
branch
2 times, most recently
from
611495a to
9ee7c2f
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a checkbox to determine if the user would actually like all active forum users(ANYWHERE on the forum) to display... since that's how the active users widget works for every other forum...