build: fix srtool build #671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 20, 2022 13:44
║ error[E0658]: use of unstable library feature 'vec_retain_mut'
║ --> /cargo-home/git/checkouts/substrate-7e08433d4c370a21/34a0621/client/transaction-pool/src/graph/validated_pool.rs:207:12
║ |
║ 207 | sinks.retain_mut(|sink| match sink.try_send(*hash) {
║ | ^^^^^^^^^^
║ |
║ = note: see issue #90829 <rust-lang/rust#90829> for more information
║ = help: add `#![feature(vec_retain_mut)]` to the crate attributes to enable
Codecov Report
@@ Coverage Diff @@
## master #671 +/- ##
=======================================
Coverage 89.60% 89.60%
=======================================
Files 33 33
Lines 6515 6515
=======================================
Hits 5838 5838
Misses 677 677 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ETeissonniere
approved these changes
Sep 23, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested the change here: https://github.com/NodleCode/chain/actions/runs/3086849701. Without it we would get: