ci: remove path checks for benchmarks #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
agostbiro
had a problem deploying
to
github-action-benchmark
GitHub Actions
Error
agostbiro
had a problem deploying
to
github-action-benchmark
GitHub Actions
Error
agostbiro
had a problem deploying
to
github-action-benchmark
GitHub Actions
Error
agostbiro
had a problem deploying
to
github-action-benchmark
GitHub Actions
Error
agostbiro
force-pushed
the
ci/remove-path-checks-for-benchmarks
branch
from
4b94810 to
9be068d
Compare
agostbiro
temporarily deployed
to
github-action-benchmark
GitHub Actions
Inactive
Wodann
approved these changes
Jul 11, 2024
fvictorio
added a commit
that referenced
this pull request
Aug 22, 2024
* edr-0.4.1 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: run prettier (#535) * test: avoid unconditional reverts in stack traces tests (#537) * fix: allow missing nonce in remote blocks (#539) * fix: allow missing nonce in remote blocks * misc: add changeset * ci: upgrade pnpm/action-setup (#541) * ci: enable some debug logs for hardhat tests (#538) * Sync with recent Hardhat changes and deduplicate the Hardhat dep (#544) * chore: Explicitly depend on semver and fs-extra in hardhat-tests Appeases ESLint. These are de facto pulled by other dependencies but it's implicit. * refactor: Unify ts-node and use the one currently used by Hardhat Deduping the hardhat package makes it easier to patch it while working on the stack trace porting feature branch. * chore: Use the newest Hardhat 2.22.6 This will make patching the changes easier to review as we will sync with the upstream as it has some changes already related to the stack traces that we port. * feat: upgrade revm dependencies (#546) * feat: upgrade revm dependencies * Create wild-phones-drum.md * edr-0.4.2 (#540) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * ci: remove path checks for benchmarks (#550) * ci: remove path restrictions for EDR jobs (#551) * ci: check that index.d.ts is up to date (#553) * feat: add support for RIP-7212 (#552) * feat: add support for RIP-7212 * misc: add changelog * fix: updated index.d.ts * fix: revert rename of InvalidFEOpcode * fix: set enableRip7212 in ProviderConfig * test: validate that disabling RIP-7212 works * refactor: use runtime variable instead of const * Path Hardhat dev dep to work with latest EDR changes EDR uses Hardhat as a dev dependency to run some javascript tests. The way this works is that the tests are run using Hardhat, but we use pnpm to override the EDR dependency in Hardhat with the local one. This works fine as long as there are no breaking changes in EDR. When there are, we have a circular dependency problem: we can't publish a new version of EDR until the tests pass, but for the tests to pass we need a version of Hardhat that works with the new version of EDR. A temporary workaround for this is to use `pnpm patch` to temporarily modify the Hardhat code in a way that works with the breaking change. In this case, this just means adding the new field when constructing the provider. --------- Co-authored-by: Franco Victorio <victorio.franco@gmail.com> * edr-0.5.0 (#555) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * build: upgrade revm to v12 (#557) * build: upgrade revm to v12 * test: remove invalid test * misc: add changeset * fix: use remote chain id for pre-fork simulation (#567) * fix: use remote chain id for pre-fork simulation * Fix error message * chore: Bump hardhat to 2.22.7 (#571) * chore: Bump hardhat to 2.22.7 * fixup: Don't enable RIP-7212 in our tests * Adapt for NomicFoundation/hardhat#5411 * fix: prevent crash when returning large JSON responses (#569) * ci: update collaborator check in the benchmarks workflow (#574) * edr-0.5.1 (#559) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: add json alias property in provider response (#582) * fix: add json alias property in provider response * Create empty-bobcats-refuse.md * edr-0.5.2 (#583) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * breaking change: rename response.json to response.data (#584) * breaking change: rename response.json to response.data * Create sour-donkeys-draw.md * Update sour-donkeys-draw.md --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Franco Victorio <victorio.franco@gmail.com> Co-authored-by: Igor Matuszewski <Xanewok@gmail.com> Co-authored-by: Agost Biro <5764438+agostbiro@users.noreply.github.com> Co-authored-by: Piotr Galar <piotr.galar@gmail.com>
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These path restrictions made sense when EDR was part of the Hardhat repo, but they can cause problems now that the EDR has its own repo (e.g. they wouldn't run if the Hardhat version was changed).