Ignition: fix for bug when we fail to save transaction hash #6229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 84a763e The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zoeyTM
force-pushed
the
ignition/tx-failure-fix
branch
from
ac7b9dc to
476d1fe
Compare
zoeyTM
force-pushed
the
ignition/tx-failure-fix
branch
from
d03bab5 to
84a763e
Compare
alcuadrado
reviewed
Feb 17, 2025
| // case 2: the user sent a different transaction that replaced ours | ||
| // so we check their transaction for the required number of confirmations | ||
| else { | ||
| return checkConfirmations( |
There was a problem hiding this comment.
I'm not sure if I understand this part, let's look at it on a call. Other than that LGTM.
There was a problem hiding this comment.
self-answer: This works because it's the else to the if in line 104. Hence, the transaction matches the sender and nonce, but not data and value. i.e. a replacement.
alcuadrado
approved these changes
Feb 20, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
TRANSACTION_PREPARE_SENDthat is written to journal immediately before sending a transaction to the networktrack-txcommand to add it to the deploymenttrack-txcommand that allows users to add a missing transaction back to their deployment. accounts for several edge cases