Check Fuel as an ItemStack #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Is there a point to having the |
|
All of that was removed in the |
|
ah, my bad. I misread the target branch |
Exaxxion
reviewed
Mar 24, 2021
src/main/java/jackyy/dimensionaledibles/block/BlockCakeBase.java
Outdated
Show resolved
Hide resolved
Exaxxion
approved these changes
Mar 25, 2021
Exaxxion
added a commit
that referenced
this pull request
Apr 9, 2021
* Switch to ItemStack for fuel * Add a fallback value for default cake fuels in case of config error * Use default behavior for getFuelItemStack Co-authored-by: Exa <11907282+Exaxxion@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remaining fix from #17 not included in the
config-refactorbranch was switching to using ItemStacks for fuel comparison. With this change, NBT data and metadata is properly respected for cake fuels.For example, the Overworld Cake is set to
oakSaplingby default for its fuel. However, it would previously accept any Vanilla Sapling. Now it is explicitly Oak.I left a method
BlockCakeBase#getFuelItemStackas separate from the one place currently calling it,BlockCakeBase#onBlockActivatedbecause I use this method again in the fuel tooltip.