Fix players spawning at Y = 0 after teleportation #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to Air instead of Netherrack at X>3 in the solid block mock world, otherwise the test will execute forever.
Forgot to bound bedrock to stop at Y=0
Exaxxion
approved these changes
Jan 29, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes players being spawned at Y = 0, or on top of the Nether roof after failing to find a suitable teleportation position into the Nether.
See #1 for the analysis. This PR is a continuation of that PR, but switched to this fork, instead of on my fork.
Notice, while testing this, I did spawn in lava one time, so it would be good if we could figure out how to include not spawning in lava as part of the 2 high empty block check.
Edit: Note an easy way to test this PR would be to set
dimPosto null in thegetDimPosmethod. This will force the creation of a new spawning location every time the player travels to the nether.