Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

bugfix: ensure field names and error interface function don't clash #34

Merged
merged 4 commits into from
Jan 8, 2024

Conversation

kegsay
Copy link
Contributor

@kegsay kegsay commented Nov 20, 2023

Fixes #30

Signed-off-by: Kegan Dougal <7190048+kegsay@users.noreply.github.com>

@kegsay kegsay requested a review from arg0d January 3, 2024 09:53
Copy link
Contributor

@arg0d arg0d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks super clean now! Just left one final request.

@kegsay kegsay requested a review from arg0d January 4, 2024 10:29
@kegsay kegsay requested a review from arg0d January 8, 2024 11:10
Copy link
Contributor

@arg0d arg0d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the contribution! Do you need this to be tagged right now?

@arg0d arg0d merged commit a2d2500 into NordSecurity:main Jan 8, 2024
3 checks passed
@kegsay
Copy link
Contributor Author

kegsay commented Jan 9, 2024

It can wait for now, as I also need #36 before I can use latest main sadly.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Naming error variant Error produces invalid code
2 participants