fix: native mode not updated focused state #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smlrq
approved these changes
Nov 29, 2024
mbwls
approved these changes
Nov 29, 2024
predikament
approved these changes
Feb 12, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we early return out of
setFocuswithnativeModeenabled - then the library will never be able to keep track of the focused elements, via callingfocusSelfI see the original change was introduced in this PR #94 (comment) - which labels the change as Good. I'm not sure if we're missing a trick - but disabling the
setFocusfunction when nativeMode is enabled means focus state can't be tracked.As this is the only function that calls
setCurrentFocusedKey, which updates the exportedfocusedprop