-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feature: add base16 support #389
Conversation
Hi Bloxx, Is it Raf who has to review the additions? |
Hey there, there is still stuff to be done so this will not be merged yet, I may end up redoing the whole theming module if I find the time, since it's kind of hard to implement base16 cleanly in the current one. I'm still working on this, stay tuned till the weekend! :) |
Please reopen this PR to target the v0.7 branch. |
I rebased the PR against 0.7. If there are any merge conflicts, GH UI should point them out. |
Didn't know that was possible |
theme/theme.nix: fix formatting supported-themes.nix: formatting clean up base16-colors.nix theme: fix plugin setup, change base16 flake input
types/theme.nix: fixed regex matching
types/types.nix: remove unneeded inherit theme/theme.nix: remove commented inherit
Co-authored-by: diniamo <55629891+diniamo@users.noreply.github.com>
You could include |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just noticed, you're missing a changelog entry in /docs/release-notes/0.7.md
If you add the entry, I think we'll be golden.
Okay, but base16 is not yet in the supported themes |
Base16 support is officially in the |
I tried pinning v.7 but this change
means my vim.autocomplete settings no longer work:
|
The autocompletion module was reworked in #404 Please refer to the changelog entry for how to migrate. |
Description
This PR aims to provide basic base16 support. This is more of a draft and by far not finished, there are several things to be improved still. base16 theming is working by now, what is to be fixed/redone:
base16-nvim
, at the momenttheme.name = "base16-nvim"
enables theming via base16, it'd be nice to just be able to usetheme.name = "base16"
.Type of change
Checklist
Please try to check at least a majority of the checklist before opening your pull request. Exceptions to this will be reviewed on a case by case basis.
nix fmt
).