Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

languages/assembly: init #447

Merged
merged 4 commits into from
Nov 9, 2024
Merged

languages/assembly: init #447

merged 4 commits into from
Nov 9, 2024

Conversation

Soliprem
Copy link
Contributor

@Soliprem Soliprem commented Nov 9, 2024

Adding support for Assembly

Sanity Checking

  • I have updated the changelog as per my changes.
  • I have tested, and self-reviewed my code.
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt).
    • My code conforms to the editorconfig configuration of the project.
    • My changes are consistent with the rest of the codebase.
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual.
    • (For breaking changes) I have included a migration guide.
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

@Soliprem Soliprem requested a review from NotAShelf as a code owner November 9, 2024 13:09
NotAShelf
NotAShelf requested changes Nov 9, 2024
View reviewed changes
Copy link
Owner

@NotAShelf NotAShelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two quick changes, LGTM otherwise.

@Soliprem Soliprem requested a review from NotAShelf November 9, 2024 18:38
@NotAShelf NotAShelf merged commit 1604c74 into NotAShelf:v0.7 Nov 9, 2024
7 checks passed
This was referenced Nov 9, 2024
Merged
Open
@github-actions github-actions bot deleted the asm branch December 15, 2024 04:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@NotAShelf NotAShelf NotAShelf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Soliprem @NotAShelf