Fix private file signed url generation #596
Merged
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Good stuff, thanks |
|
Thanks @worgho2 🙏 |
|
@transitive-bullshit this is not yet published a new version, right? |
Correct; will publish soon. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When trying to display a PDF file, I've figured out that notion is using a new bucket url to serve their files and it impacts how this library handles url signing.
https://s3-us-west-2.amazonaws.com/secure.notion-static.com/...https://prod-files-secure.s3.us-west-2.amazonaws.com/...Including
prod-files-secureprefix when identifying a private url, fixed the issue.Other than that, the PDF component is using an outdated
pdfjs-distcdn url, so i've updated it.Notion Test Page ID
34d650c65da34f888335dbd3ddd141dc