New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix request.data handling #436

Merged

DimaDemchenko merged 1 commit into main from fix/data-handling

Nov 18, 2024

Member

mrlika commented Nov 17, 2024 •

edited

Loading

request.data is always undefined here that causes peers' protocol failure:

const isWrongSegment =
  !request.data ||
  downloadingContext.request.segment.externalId !== command.i ||
  downloadingContext.requestId !== command.r;


          Fix request.data handling

5c9c892

mrlika requested a review from DimaDemchenko

November 17, 2024 00:02

DimaDemchenko approved these changes

View reviewed changes

DimaDemchenko merged commit 7f2f1fa into main

3 checks passed

DimaDemchenko deleted the fix/data-handling branch

November 18, 2024 08:23

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet